[PR #3060] [MERGED] Indicate which pane is focused with the Accent color on the pan… #25230

Open
opened 2026-01-31 09:08:07 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/3060
Author: @zadjii-msft
Created: 10/4/2019
Status: Merged
Merged: 11/1/2019
Merged by: @zadjii-msft

Base: masterHead: dev/migrie/f/994-pane-focus-borders


📝 Commits (10+)

  • c5e8361 start work on this by tracking border state
  • a26b1c9 Colorize the border
  • b078e9a Use the accent color for highlighting
  • f49e57f Cleanup the accent color code
  • c914f64 Don't buy any rural real estate when closing a pane
  • d9d49d4 Closing panes works well now too
  • 79872c1 Cleanup for review
  • 3226db3 Update src/cascadia/TerminalApp/Pane.cpp
  • 127f8da Merge branch 'master' into dev/migrie/f/994-pane-focus-borders
  • dda2e29 Merge branch 'dev/migrie/f/994-pane-focus-borders' of https://github.com/Microsoft/Terminal into dev/migrie/f/994-pane-focus-borders

📊 Changes

2 files changed (+163 additions, -54 deletions)

View changed files

📝 src/cascadia/TerminalApp/Pane.cpp (+148 -53)
📝 src/cascadia/TerminalApp/Pane.h (+15 -1)

📄 Description

Summary of the Pull Request

Adds a small border with the accent color to indicate a pane is focused

PR Checklist

Detailed Description of the Pull Request / Additional comments

I've removed the simple Grid we were using as the pane separator, and replaced it with a Border that might appear on any side of a pane.

When we add a split, we'll create each child with one of the Border flags set (each child with one of a pair of flags). E.g. creating a horizontal split creates one child with the Top border, and another with the Bottom.

Then, if one of those panes is split, it will pass it's border flag to is new children, with the additional flag set. So adding another Vertical split to the above scenario would create a set of panes with either (Top|Left, Top|Right) or (Bottom|Left, Bottom|Right) borders set, depending on which pane was split.

Validation Steps Performed

Some playing with it, but honestly it needs more for me to be totally confident.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/3060 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 10/4/2019 **Status:** ✅ Merged **Merged:** 11/1/2019 **Merged by:** [@zadjii-msft](https://github.com/zadjii-msft) **Base:** `master` ← **Head:** `dev/migrie/f/994-pane-focus-borders` --- ### 📝 Commits (10+) - [`c5e8361`](https://github.com/microsoft/terminal/commit/c5e83610a23ae5b8f53df756abea70baf568b061) start work on this by tracking border state - [`a26b1c9`](https://github.com/microsoft/terminal/commit/a26b1c92fc33f1c9341c2fa05c107a9ed9a55f53) Colorize the border - [`b078e9a`](https://github.com/microsoft/terminal/commit/b078e9a07656d1d4f465860d19022eb08150a89a) Use the accent color for highlighting - [`f49e57f`](https://github.com/microsoft/terminal/commit/f49e57ff2b5bdd2d7ba37b59838de4f7b3328293) Cleanup the accent color code - [`c914f64`](https://github.com/microsoft/terminal/commit/c914f64122f9b512e92615bf7f42475bbda765eb) Don't buy any rural real estate when closing a pane - [`d9d49d4`](https://github.com/microsoft/terminal/commit/d9d49d485df7e79bfbfb994d36c46e267c9225dc) Closing panes works well now too - [`79872c1`](https://github.com/microsoft/terminal/commit/79872c183cdbb5c33b0e3edfb952835f1a4b70fa) Cleanup for review - [`3226db3`](https://github.com/microsoft/terminal/commit/3226db3131d69db151b640fcac8012bcc92c5f4a) Update src/cascadia/TerminalApp/Pane.cpp - [`127f8da`](https://github.com/microsoft/terminal/commit/127f8da580cc2feb9459f774cfda9f2374a5d59a) Merge branch 'master' into dev/migrie/f/994-pane-focus-borders - [`dda2e29`](https://github.com/microsoft/terminal/commit/dda2e299432e7fbff011f9087aacb91608a03a13) Merge branch 'dev/migrie/f/994-pane-focus-borders' of https://github.com/Microsoft/Terminal into dev/migrie/f/994-pane-focus-borders ### 📊 Changes **2 files changed** (+163 additions, -54 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/Pane.cpp` (+148 -53) 📝 `src/cascadia/TerminalApp/Pane.h` (+15 -1) </details> ### 📄 Description ## Summary of the Pull Request Adds a small border with the accent color to indicate a pane is focused <img src="https://user-images.githubusercontent.com/18356694/66218711-560e4b80-e68f-11e9-85b0-1f387d35bb92.png" width="480"> <img src="https://user-images.githubusercontent.com/18356694/66218757-6f16fc80-e68f-11e9-8d39-db9ab748c4de.png" width="480"> <img src="https://user-images.githubusercontent.com/18356694/66219194-55c28000-e690-11e9-9835-8b5212e70e8a.png" width="480"> ## PR Checklist * [x] Closes #994 * [x] I work here * [😢] Tests added/passed * [n/a] Requires documentation to be updated ## Detailed Description of the Pull Request / Additional comments I've removed the simple Grid we were using as the pane separator, and replaced it with a Border that might appear on any side of a pane. When we add a split, we'll create each child with one of the `Border` flags set (each child with one of a pair of flags). E.g. creating a horizontal split creates one child with the `Top` border, and another with the `Bottom`. Then, if one of those panes is split, it will pass it's border flag to is new children, with the additional flag set. So adding another Vertical split to the above scenario would create a set of panes with either (`Top|Left`, `Top|Right`) or (`Bottom|Left`, `Bottom|Right`) borders set, depending on which pane was split. ## Validation Steps Performed Some playing with it, but honestly it needs more for me to be totally confident. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:08:07 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25230