starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 00:15:10 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #3051] [MERGED] Upgrade UiaProviders to WRL::ComPtr #25232

New Issue
Open
opened 2026-01-31 09:08:08 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:08:08 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/3051
Author: @carlos-zamora
Created: 10/4/2019
Status: ✅ Merged
Merged: 11/22/2019
Merged by: @carlos-zamora

Base: master ← Head: dev/cazamor/acc/wil-upgrade

📝 Commits (10+)

  • 7a310c8 Switch to WRL::ComPtr for ScreenInfoUiaProvider and UiaTextRange
  • b331937 Upgrade WindowUiaProvider
  • 1aa2b0d Make CreateUTR functions return HRESULT and use outptr
  • f60246b Cleaner creation process with proper RETURN_IF_FAILED() and returning S_OK
  • 87f6c5c Code formatter
  • 81543c4 fix merge conflicts
  • 9d57e06 fix static analysis errors
  • b33dd6d Add warning suppression for dumb computer thing
  • 0077a46 Applied feedback.
  • f9ad0a1 fix merge conflicts

📊 Changes

27 files changed (+519 additions, -779 deletions)

View changed files

📝 src/cascadia/TerminalApp/App.cpp (+6 -6)
📝 src/cascadia/TerminalControl/TermControl.cpp (+8 -5)
📝 src/cascadia/TerminalControl/TermControlAutomationPeer.cpp (+12 -10)
📝 src/cascadia/TerminalControl/TermControlAutomationPeer.h (+2 -2)
📝 src/cascadia/TerminalControl/TermControlUiaProvider.cpp (+65 -29)
📝 src/cascadia/TerminalControl/TermControlUiaProvider.hpp (+17 -13)
📝 src/cascadia/TerminalControl/UiaTextRange.cpp (+48 -119)
📝 src/cascadia/TerminalControl/UiaTextRange.hpp (+20 -36)
📝 src/cascadia/WindowsTerminal/IslandWindow.cpp (+2 -1)
📝 src/cascadia/WindowsTerminal/WindowUiaProvider.cpp (+4 -8)
📝 src/cascadia/WindowsTerminal/WindowUiaProvider.hpp (+2 -3)
📝 src/inc/LibraryIncludes.h (+3 -0)
📝 src/interactivity/win32/screenInfoUiaProvider.cpp (+63 -27)
📝 src/interactivity/win32/screenInfoUiaProvider.hpp (+17 -13)
📝 src/interactivity/win32/uiaTextRange.cpp (+47 -150)
📝 src/interactivity/win32/uiaTextRange.hpp (+20 -36)
📝 src/interactivity/win32/ut_interactivity_win32/UiaTextRangeTests.cpp (+27 -26)
📝 src/interactivity/win32/window.cpp (+4 -17)
📝 src/interactivity/win32/window.hpp (+1 -1)
📝 src/interactivity/win32/windowUiaProvider.cpp (+13 -52)

...and 7 more files

📄 Description

Summary of the Pull Request

UiaTextRangeBase and ScreenInfoUiaProviderBase take on the bulk of this change. They were changed to WRL RuntimeClasses. Any references to them have been updated too.

PR Checklist

Detailed Description of the Pull Request / Additional comments

Pretty straightforward. Please double check if I'm handling ownership properly.

Validation Steps Performed

It builds and works with Narrator just like it did before.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/3051 **Author:** [@carlos-zamora](https://github.com/carlos-zamora) **Created:** 10/4/2019 **Status:** ✅ Merged **Merged:** 11/22/2019 **Merged by:** [@carlos-zamora](https://github.com/carlos-zamora) **Base:** `master` ← **Head:** `dev/cazamor/acc/wil-upgrade` --- ### 📝 Commits (10+) - [`7a310c8`](https://github.com/microsoft/terminal/commit/7a310c8096f6638d7b32bee7b5e016e7706229e5) Switch to WRL::ComPtr for ScreenInfoUiaProvider and UiaTextRange - [`b331937`](https://github.com/microsoft/terminal/commit/b3319373f4ebe0e28057fcb059be53202f8d8b0f) Upgrade WindowUiaProvider - [`1aa2b0d`](https://github.com/microsoft/terminal/commit/1aa2b0d3f0501e7f67b17e6016bfae4d4f4bbf44) Make CreateUTR functions return HRESULT and use outptr - [`f60246b`](https://github.com/microsoft/terminal/commit/f60246b26f88e0a62085001aa8392b302d328117) Cleaner creation process with proper RETURN_IF_FAILED() and returning S_OK - [`87f6c5c`](https://github.com/microsoft/terminal/commit/87f6c5cf279f5cc0e5f36536e63f8c7e1359aac6) Code formatter - [`81543c4`](https://github.com/microsoft/terminal/commit/81543c44ee52481f907878d304174bb38eb79f1b) fix merge conflicts - [`9d57e06`](https://github.com/microsoft/terminal/commit/9d57e062795a4dbb9464a73aad6773f996b3ca81) fix static analysis errors - [`b33dd6d`](https://github.com/microsoft/terminal/commit/b33dd6d8acb055fa8afd725e8480638c8a21272e) Add warning suppression for dumb computer thing - [`0077a46`](https://github.com/microsoft/terminal/commit/0077a46d7b9b87af526efdc17474ecef4b4a95fd) Applied feedback. - [`f9ad0a1`](https://github.com/microsoft/terminal/commit/f9ad0a1c7418228d088bff5de46a002531aa192d) fix merge conflicts ### 📊 Changes **27 files changed** (+519 additions, -779 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/App.cpp` (+6 -6) 📝 `src/cascadia/TerminalControl/TermControl.cpp` (+8 -5) 📝 `src/cascadia/TerminalControl/TermControlAutomationPeer.cpp` (+12 -10) 📝 `src/cascadia/TerminalControl/TermControlAutomationPeer.h` (+2 -2) 📝 `src/cascadia/TerminalControl/TermControlUiaProvider.cpp` (+65 -29) 📝 `src/cascadia/TerminalControl/TermControlUiaProvider.hpp` (+17 -13) 📝 `src/cascadia/TerminalControl/UiaTextRange.cpp` (+48 -119) 📝 `src/cascadia/TerminalControl/UiaTextRange.hpp` (+20 -36) 📝 `src/cascadia/WindowsTerminal/IslandWindow.cpp` (+2 -1) 📝 `src/cascadia/WindowsTerminal/WindowUiaProvider.cpp` (+4 -8) 📝 `src/cascadia/WindowsTerminal/WindowUiaProvider.hpp` (+2 -3) 📝 `src/inc/LibraryIncludes.h` (+3 -0) 📝 `src/interactivity/win32/screenInfoUiaProvider.cpp` (+63 -27) 📝 `src/interactivity/win32/screenInfoUiaProvider.hpp` (+17 -13) 📝 `src/interactivity/win32/uiaTextRange.cpp` (+47 -150) 📝 `src/interactivity/win32/uiaTextRange.hpp` (+20 -36) 📝 `src/interactivity/win32/ut_interactivity_win32/UiaTextRangeTests.cpp` (+27 -26) 📝 `src/interactivity/win32/window.cpp` (+4 -17) 📝 `src/interactivity/win32/window.hpp` (+1 -1) 📝 `src/interactivity/win32/windowUiaProvider.cpp` (+13 -52) _...and 7 more files_ </details> ### 📄 Description ## Summary of the Pull Request `UiaTextRangeBase` and `ScreenInfoUiaProviderBase` take on the bulk of this change. They were changed to WRL RuntimeClasses. Any references to them have been updated too. <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [x] Closes #2474 * [x] CLA signed. * [x] ~Tests added/passed~ * [x] ~Requires documentation to be updated~ <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments Pretty straightforward. Please double check if I'm handling ownership properly. <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed It builds and works with Narrator just like it did before. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:08:08 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25232
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?