starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #3213] [MERGED] Switch all of the UIA providers to WRL::RuntimeClass #25270

New Issue
Open
opened 2026-01-31 09:08:25 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:08:25 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/3213
Author: @DHowett-MSFT
Created: 10/15/2019
Status: ✅ Merged
Merged: 10/17/2019
Merged by: @miniksa

Base: master ← Head: dev/duhowett/steals/from/carlos

📝 Commits (4)

  • b0f0d69 Switch all of the UIA providers to WRL::RuntimeClass
  • 100f3b9 Appease the various automatic tools
  • 5ba49be broadly, consider building the tests too
  • 1c92e9e djkhsdkljafshf

📊 Changes

16 files changed (+63 additions, -232 deletions)

View changed files

📝 src/cascadia/TerminalControl/UiaTextRange.cpp (+10 -9)
📝 src/cascadia/TerminalControl/UiaTextRange.hpp (+6 -7)
📝 src/cascadia/WindowsTerminal/WindowUiaProvider.cpp (+1 -1)
📝 src/cascadia/WindowsTerminal/WindowUiaProvider.hpp (+3 -4)
📝 src/cascadia/WindowsTerminal/main.cpp (+4 -4)
📝 src/interactivity/win32/uiaTextRange.cpp (+10 -10)
📝 src/interactivity/win32/uiaTextRange.hpp (+6 -6)
📝 src/interactivity/win32/ut_interactivity_win32/UiaTextRangeTests.cpp (+7 -7)
📝 src/interactivity/win32/windowUiaProvider.cpp (+2 -2)
📝 src/interactivity/win32/windowUiaProvider.hpp (+3 -3)
📝 src/types/ScreenInfoUiaProviderBase.cpp (+0 -51)
📝 src/types/ScreenInfoUiaProviderBase.h (+4 -15)
📝 src/types/UiaTextRangeBase.cpp (+0 -49)
📝 src/types/UiaTextRangeBase.hpp (+3 -10)
📝 src/types/WindowUiaProviderBase.cpp (+0 -42)
📝 src/types/WindowUiaProviderBase.hpp (+4 -12)

📄 Description

Fixes #3209.
References #3051.

I stole a bunch of Carlos's changes from #3051. I'll help him merge them back in later.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/3213 **Author:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Created:** 10/15/2019 **Status:** ✅ Merged **Merged:** 10/17/2019 **Merged by:** [@miniksa](https://github.com/miniksa) **Base:** `master` ← **Head:** `dev/duhowett/steals/from/carlos` --- ### 📝 Commits (4) - [`b0f0d69`](https://github.com/microsoft/terminal/commit/b0f0d69c4bf8d5edb4aad245e189f487236ba51d) Switch all of the UIA providers to WRL::RuntimeClass - [`100f3b9`](https://github.com/microsoft/terminal/commit/100f3b98289ef97fbb50e0536a61157d7825e815) Appease the various automatic tools - [`5ba49be`](https://github.com/microsoft/terminal/commit/5ba49bebc10a640d8e2312d5f74ab7847d72560c) broadly, consider building the tests too - [`1c92e9e`](https://github.com/microsoft/terminal/commit/1c92e9e9e1fef62f487db5817c84aea4b0115c4e) djkhsdkljafshf ### 📊 Changes **16 files changed** (+63 additions, -232 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalControl/UiaTextRange.cpp` (+10 -9) 📝 `src/cascadia/TerminalControl/UiaTextRange.hpp` (+6 -7) 📝 `src/cascadia/WindowsTerminal/WindowUiaProvider.cpp` (+1 -1) 📝 `src/cascadia/WindowsTerminal/WindowUiaProvider.hpp` (+3 -4) 📝 `src/cascadia/WindowsTerminal/main.cpp` (+4 -4) 📝 `src/interactivity/win32/uiaTextRange.cpp` (+10 -10) 📝 `src/interactivity/win32/uiaTextRange.hpp` (+6 -6) 📝 `src/interactivity/win32/ut_interactivity_win32/UiaTextRangeTests.cpp` (+7 -7) 📝 `src/interactivity/win32/windowUiaProvider.cpp` (+2 -2) 📝 `src/interactivity/win32/windowUiaProvider.hpp` (+3 -3) 📝 `src/types/ScreenInfoUiaProviderBase.cpp` (+0 -51) 📝 `src/types/ScreenInfoUiaProviderBase.h` (+4 -15) 📝 `src/types/UiaTextRangeBase.cpp` (+0 -49) 📝 `src/types/UiaTextRangeBase.hpp` (+3 -10) 📝 `src/types/WindowUiaProviderBase.cpp` (+0 -42) 📝 `src/types/WindowUiaProviderBase.hpp` (+4 -12) </details> ### 📄 Description Fixes #3209. References #3051. I stole a bunch of Carlos's changes from #3051. I'll help him merge them back in later. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:08:25 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25270
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?