[PR #3212] [MERGED] Revert "Patch fix for #1360 (#2924)" #25271

Open
opened 2026-01-31 09:08:25 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/3212
Author: @DHowett-MSFT
Created: 10/15/2019
Status: Merged
Merged: 10/16/2019
Merged by: @DHowett-MSFT

Base: masterHead: revert-2924-dev/miniksa/1360


📝 Commits (1)

📊 Changes

3 files changed (+0 additions, -105 deletions)

View changed files

📝 src/cascadia/TerminalCore/Terminal.cpp (+0 -12)
src/cascadia/UnitTests_TerminalCore/TerminalApiTests.cpp (+0 -92)
📝 src/cascadia/UnitTests_TerminalCore/UnitTests.vcxproj (+0 -1)

📄 Description

Reverts microsoft/terminal#2924

Reopens #1360.

Fixes #3052.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/3212 **Author:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Created:** 10/15/2019 **Status:** ✅ Merged **Merged:** 10/16/2019 **Merged by:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Base:** `master` ← **Head:** `revert-2924-dev/miniksa/1360` --- ### 📝 Commits (1) - [`6a35f5f`](https://github.com/microsoft/terminal/commit/6a35f5fe781cb40049214b0daf36fb9c71127130) Revert "Patch fix for #1360 until WriteStream (#780) can be implemented. (#2924)" ### 📊 Changes **3 files changed** (+0 additions, -105 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalCore/Terminal.cpp` (+0 -12) ➖ `src/cascadia/UnitTests_TerminalCore/TerminalApiTests.cpp` (+0 -92) 📝 `src/cascadia/UnitTests_TerminalCore/UnitTests.vcxproj` (+0 -1) </details> ### 📄 Description Reverts microsoft/terminal#2924 Reopens #1360. Fixes #3052. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:08:25 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25271