starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #3282] [MERGED] Manipulate Xterm256Engine's extended attr state properly #25300

New Issue
Open
opened 2026-01-31 09:08:37 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:08:37 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/3282
Author: @DHowett-MSFT
Created: 10/22/2019
Status: ✅ Merged
Merged: 10/24/2019
Merged by: @DHowett-MSFT

Base: master ← Head: dev/duhowett/exten

📝 Commits (2)

  • 5fad96c Manipulate Xterm256Engine's extended attr state properly
  • 1b0ebb3 Add a test for extended attributes

📊 Changes

2 files changed (+104 additions, -1 deletions)

View changed files

📝 src/host/ut_host/VtRendererTests.cpp (+103 -0)
📝 src/renderer/vt/Xterm256Engine.cpp (+1 -1)

📄 Description

We should be clearing the bits when they're different, not just always
setting them.

Fixes #3281.

The tests should have caught this. I'll send in more tests.

PR Checklist

  • Closes Feature Request (#3281)
  • CLA signed
  • Tests added/passed
  • Requires documentation to be updated
  • I'm riding the core train

Validation Steps Performed

Replaced conhost on my system, tried vim's terminal which does support those SGRs.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/3282 **Author:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Created:** 10/22/2019 **Status:** ✅ Merged **Merged:** 10/24/2019 **Merged by:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Base:** `master` ← **Head:** `dev/duhowett/exten` --- ### 📝 Commits (2) - [`5fad96c`](https://github.com/microsoft/terminal/commit/5fad96c3e1c93a7f17a45d16d65362c002f74f96) Manipulate Xterm256Engine's extended attr state properly - [`1b0ebb3`](https://github.com/microsoft/terminal/commit/1b0ebb308ff43d14042bffb2824389b5590bd238) Add a test for extended attributes ### 📊 Changes **2 files changed** (+104 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/host/ut_host/VtRendererTests.cpp` (+103 -0) 📝 `src/renderer/vt/Xterm256Engine.cpp` (+1 -1) </details> ### 📄 Description We should be clearing the bits when they're different, not just always setting them. Fixes #3281. The tests should have caught this. I'll send in more tests. ## PR Checklist * [x] Closes #3281 * [x] CLA signed * [ ] Tests added/passed * [ ] Requires documentation to be updated * [x] I'm riding the core train ## Validation Steps Performed Replaced conhost on my system, tried vim's terminal which does support those SGRs. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:08:37 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25300
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?