starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #3314] [CLOSED] Replace \r\n with \r to get rid of double newlines #25309

New Issue
Open
opened 2026-01-31 09:08:40 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:08:40 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/3314
Author: @ShutterQuick
Created: 10/24/2019
Status: ❌ Closed

Base: master ← Head: feature/stripNewline

📝 Commits (1)

  • 7298025 Replace \r\n with \r to get rid of double newlines

📊 Changes

2 files changed (+15 additions, -1 deletions)

View changed files

📝 src/cascadia/TerminalControl/TermControl.cpp (+14 -1)
📝 src/cascadia/TerminalControl/TermControl.h (+1 -0)

📄 Description

Summary of the Pull Request

Continuation of https://github.com/microsoft/terminal/pull/2390
As this MR seems to have been abandoned, I'm opening a new one with the same change.
As per the discussion in #2390, unconditionally replace \r\n with \r.

References

https://github.com/microsoft/terminal/pull/2390
https://github.com/microsoft/terminal/pull/1094
https://github.com/microsoft/terminal/issues/1091

PR Checklist

  • Closes Ligatures do not render under cursor column in Vim (#1091)
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

I'm sure I'm not the only one going insane from hitting this bug all the time.
Please let me know what extra steps I need to take with this MR to get it merged.

Rudely CC-ing @DHowett-MSFT, who seems to have been active on #2390.

Validation Steps Performed

No unit tests are added.

Manually verified the terminal to, with this patch, have the same behavior as the built in Windows Command Prompt by writing a program that list out what keys are pressed, and then paste

a
b
c
d

From left to right: 0.5.2762.0, this branch, Windows built in Command Prompt.
image

Manually tested that pasting now works as expected in vim both on Windows and WSL2.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/3314 **Author:** [@ShutterQuick](https://github.com/ShutterQuick) **Created:** 10/24/2019 **Status:** ❌ Closed **Base:** `master` ← **Head:** `feature/stripNewline` --- ### 📝 Commits (1) - [`7298025`](https://github.com/microsoft/terminal/commit/7298025b9c2979293008a163ab82d5a8b67a29c9) Replace \r\n with \r to get rid of double newlines ### 📊 Changes **2 files changed** (+15 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalControl/TermControl.cpp` (+14 -1) 📝 `src/cascadia/TerminalControl/TermControl.h` (+1 -0) </details> ### 📄 Description ## Summary of the Pull Request Continuation of https://github.com/microsoft/terminal/pull/2390 As this MR seems to have been abandoned, I'm opening a new one with the same change. As per the discussion in #2390, unconditionally replace `\r\n` with `\r`. ## References https://github.com/microsoft/terminal/pull/2390 https://github.com/microsoft/terminal/pull/1094 https://github.com/microsoft/terminal/issues/1091 ## PR Checklist * [X] Closes #1091 * [X] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Requires documentation to be updated * [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx ## Detailed Description of the Pull Request / Additional comments I'm sure I'm not the only one going insane from hitting this bug all the time. Please let me know what extra steps I need to take with this MR to get it merged. Rudely CC-ing @DHowett-MSFT, who seems to have been active on #2390. ## Validation Steps Performed No unit tests are added. Manually verified the terminal to, with this patch, have the same behavior as the built in Windows Command Prompt by writing a program that list out what keys are pressed, and then paste ``` a b c d ``` From left to right: 0.5.2762.0, this branch, Windows built in Command Prompt. ![image](https://user-images.githubusercontent.com/2367571/67499154-e2090700-f680-11e9-8907-43dfd653d4c1.png) Manually tested that pasting now works as expected in vim both on Windows and WSL2. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:08:40 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25309
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?