starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #3292] [MERGED] Revert two cursor changes that cause crashing and rendering artifacts #25312

New Issue
Open
opened 2026-01-31 09:08:40 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:08:40 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/3292
Author: @DHowett-MSFT
Created: 10/22/2019
Status: ✅ Merged
Merged: 10/22/2019
Merged by: @miniksa

Base: master ← Head: dev/duhowett/actually_just_revert

📝 Commits (1)

  • 549369e Revert two cursor changes that cause crashing and rendering artifacts

📊 Changes

3 files changed (+1 additions, -23 deletions)

View changed files

📝 src/cascadia/TerminalCore/Terminal.cpp (+0 -19)
📝 src/cascadia/TerminalCore/Terminal.hpp (+0 -1)
📝 src/cascadia/TerminalCore/terminalrenderdata.cpp (+1 -3)

📄 Description

Revert "Fix cursor redrawing crash (#2965)"
This reverts commit 926a2e3d80.

Revert "Fix double width cursor for CJK characters (#2932)"
This reverts commit eafa884fc4.

Fixes #3277.
Fully reverts #2965, #2932.

Summary of the Pull Request

Chatted with @skyline75489 about the appropriate fix for #3277, and we decided that it'd be best to revert these two PRs until we can get them in better shape.

PR Checklist

Validation

A whole bunch of bisecting.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/3292 **Author:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Created:** 10/22/2019 **Status:** ✅ Merged **Merged:** 10/22/2019 **Merged by:** [@miniksa](https://github.com/miniksa) **Base:** `master` ← **Head:** `dev/duhowett/actually_just_revert` --- ### 📝 Commits (1) - [`549369e`](https://github.com/microsoft/terminal/commit/549369ecc83efb2379fdb6db4523fd6ed0270c8a) Revert two cursor changes that cause crashing and rendering artifacts ### 📊 Changes **3 files changed** (+1 additions, -23 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalCore/Terminal.cpp` (+0 -19) 📝 `src/cascadia/TerminalCore/Terminal.hpp` (+0 -1) 📝 `src/cascadia/TerminalCore/terminalrenderdata.cpp` (+1 -3) </details> ### 📄 Description Revert "Fix cursor redrawing crash (#2965)" This reverts commit 926a2e3d800a18a23139f8c6e9f97f3ccf63650c. Revert "Fix double width cursor for CJK characters (#2932)" This reverts commit eafa884fc40e566c4df4a4521850b14130a7ff24. Fixes #3277. Fully reverts #2965, #2932. ## Summary of the Pull Request Chatted with @skyline75489 about the appropriate fix for #3277, and we decided that it'd be best to revert these two PRs until we can get them in better shape. ## PR Checklist * [x] Closes #3277 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [x] Tests added/passed * [ ] Requires documentation to be updated * [x] . ## Validation A whole bunch of bisecting. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:08:40 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25312
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?