[PR #3288] CascadiaSettings: Use map to find matching color scheme #25316

Open
opened 2026-01-31 09:08:41 +00:00 by claunia · 0 comments
Owner

Original Pull Request: https://github.com/microsoft/terminal/pull/3288

State: closed
Merged: Yes


Summary of the Pull Request

The _FindMatchingColorScheme function currently iterates through all pairs in
the map to find the matching color scheme for a given JSON.

Improved this by using the name from the JSON to lookup the color scheme
in the map.

Closes #3200

Testing

Verified that UTs are passing (especially ColorSchemeTests)

**Original Pull Request:** https://github.com/microsoft/terminal/pull/3288 **State:** closed **Merged:** Yes --- ## Summary of the Pull Request The `_FindMatchingColorScheme` function currently iterates through all pairs in the map to find the matching color scheme for a given JSON. Improved this by using the name from the JSON to lookup the color scheme in the map. Closes #3200 ### Testing Verified that UTs are passing (especially `ColorSchemeTests`)
claunia added the pull-request label 2026-01-31 09:08:41 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25316