[PR #3369] [CLOSED] Add support for "User Default" settings #25328

Open
opened 2026-01-31 09:08:47 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/3369
Author: @zadjii-msft
Created: 10/29/2019
Status: Closed

Base: masterHead: dev/migrie/b/2325-default-profile


📝 Commits (4)

  • fb11f95 Add support for "User Default" settings
  • 5bcd7dd Update the schema, SettingsSchema.md
  • 5de8d40 Merge remote-tracking branch 'origin/master' into dev/migrie/b/2325-default-profile
  • c569f89 Docs for dayyyyys

📊 Changes

6 files changed (+656 additions, -251 deletions)

View changed files

📝 doc/cascadia/SettingsSchema.md (+1 -0)
📝 doc/cascadia/profiles.schema.json (+258 -250)
📝 doc/user-docs/UsingJsonSettings.md (+107 -0)
📝 src/cascadia/LocalTests_TerminalApp/SettingsTests.cpp (+230 -0)
📝 src/cascadia/TerminalApp/CascadiaSettings.h (+3 -0)
📝 src/cascadia/TerminalApp/CascadiaSettingsSerialization.cpp (+57 -1)

📄 Description

Summary of the Pull Request

These are settings that apply to every profile, before user customizations. This can be placed in the globals under the "defaultSettings" key. It's a blob of profile settings that will be parsed just like a profile, and applied to profiles after default&dynamic profiles, but before user profiles.

"defaultSettings" is kinda a placeholder key ATM - @cinnamon-msft do we have concerns with this name? Does it make enough sense?

References

#2515, #2603

PR Checklist

Detailed Description of the Pull Request / Additional comments

Discussion in #2325 itself serves as the "spec" for this task. I thought we'd need more discussion on the topic, but it ended up being pretty straightforward.

Validation Steps Performed

ran the tests


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/3369 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 10/29/2019 **Status:** ❌ Closed **Base:** `master` ← **Head:** `dev/migrie/b/2325-default-profile` --- ### 📝 Commits (4) - [`fb11f95`](https://github.com/microsoft/terminal/commit/fb11f952653967620efb8c1439e1bc57229f9caf) Add support for "User Default" settings - [`5bcd7dd`](https://github.com/microsoft/terminal/commit/5bcd7dda6b46af84efeada919f540be5dcea8e4b) Update the schema, SettingsSchema.md - [`5de8d40`](https://github.com/microsoft/terminal/commit/5de8d40e7518c284270a169fca5b056eed19d375) Merge remote-tracking branch 'origin/master' into dev/migrie/b/2325-default-profile - [`c569f89`](https://github.com/microsoft/terminal/commit/c569f8960ebed644bfb93d6c26deeb18a1f8d3c6) Docs for dayyyyys ### 📊 Changes **6 files changed** (+656 additions, -251 deletions) <details> <summary>View changed files</summary> 📝 `doc/cascadia/SettingsSchema.md` (+1 -0) 📝 `doc/cascadia/profiles.schema.json` (+258 -250) 📝 `doc/user-docs/UsingJsonSettings.md` (+107 -0) 📝 `src/cascadia/LocalTests_TerminalApp/SettingsTests.cpp` (+230 -0) 📝 `src/cascadia/TerminalApp/CascadiaSettings.h` (+3 -0) 📝 `src/cascadia/TerminalApp/CascadiaSettingsSerialization.cpp` (+57 -1) </details> ### 📄 Description ## Summary of the Pull Request These are settings that apply to _every_ profile, before user customizations. This can be placed in the globals under the "defaultSettings" key. It's a blob of profile settings that will be parsed just like a profile, and applied to profiles after default&dynamic profiles, but before user profiles. "defaultSettings" is kinda a placeholder key ATM - @cinnamon-msft do we have concerns with this name? Does it make enough sense? ## References #2515, #2603 ## PR Checklist * [x] Closes #2325 * [x] I work here * [x] Tests added/passed * [x] schema, docs updated ## Detailed Description of the Pull Request / Additional comments Discussion in #2325 itself serves as the "spec" for this task. I thought we'd need more discussion on the topic, but it ended up being pretty straightforward. ## Validation Steps Performed _ran the tests_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:08:47 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25328