[PR #3412] [MERGED] Fix our parallel (and repeating) builds #25348

Open
opened 2026-01-31 09:08:56 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/3412
Author: @DHowett-MSFT
Created: 11/1/2019
Status: ✅ Merged
Merged: 11/1/2019
Merged by: @DHowett-MSFT

Base: master ← Head: dev/duhowett/fix_the_build_some_more


📝 Commits (2)

  • e3dae78 Remove WpfTerminalControl AnyCPU from Arch-specific builds
  • 5fe8cb0 Fix our parallel (and repeating) builds

📊 Changes

4 files changed (+47 additions, -28 deletions)

View changed files

📝 OpenConsole.sln (+9 -16)
📝 build/pipelines/templates/build-console-steps.yml (+20 -3)
📝 src/cascadia/WpfTerminalControl/WpfTerminalControl.csproj (+0 -4)
📝 src/common.build.post.props (+18 -5)

📄 Description

Summary of the Pull Request

Fix our parallel (and repeating) builds

The WAP packaging project in VS <= 16.3.7 produces a couple global
properties as part of its normal operation that cause MSBuild to flag
our projects as out-of-date and requiring a rebuild. By forcing those
properties to match the WAP values, we can get consistent builds.

One of those properties, however, is "GenerateAppxPackageOnBuild", and
WAP sets it to false. When we set that, of course, we don't get an
MSIX out of our build pipeline. Therefore, we have to break our build
into two phases -- build, then package.

This required us to change our approach to PCH deletion. A project
without a PCH is also considered out-of-date. Now, we keep all PCH
files but truncate them to 0 bytes.

TerminalApp, however, is re-linked during packaging because the Xaml
compiler emits a new generated C++ file on every build. We have to keep
those PCHs around.

This pull request also removes another source of build nondeterminism: that WpfTerminalControl was propagating TargetFramework into architecture-specific C++ builds. Its "Any CPU" platform has been removed from architecture builds at the solution level.

PR Checklist

  • Closes #(none)
  • CLA
  • Tests added/passed/did a lot of builds
  • Requires documentation to be updated
  • I've discussed this with core contributors already.

Validation Steps Performed

I ran so many freakin' builds.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/3412 **Author:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Created:** 11/1/2019 **Status:** ✅ Merged **Merged:** 11/1/2019 **Merged by:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Base:** `master` ← **Head:** `dev/duhowett/fix_the_build_some_more` --- ### 📝 Commits (2) - [`e3dae78`](https://github.com/microsoft/terminal/commit/e3dae783876bbe0a075da3264a96bcc244ad52a4) Remove WpfTerminalControl AnyCPU from Arch-specific builds - [`5fe8cb0`](https://github.com/microsoft/terminal/commit/5fe8cb0847f166713d7a83fe5805b404725de1eb) Fix our parallel (and repeating) builds ### 📊 Changes **4 files changed** (+47 additions, -28 deletions) <details> <summary>View changed files</summary> 📝 `OpenConsole.sln` (+9 -16) 📝 `build/pipelines/templates/build-console-steps.yml` (+20 -3) 📝 `src/cascadia/WpfTerminalControl/WpfTerminalControl.csproj` (+0 -4) 📝 `src/common.build.post.props` (+18 -5) </details> ### 📄 Description ## Summary of the Pull Request Fix our parallel (and repeating) builds The WAP packaging project in VS <= 16.3.7 produces a couple global properties as part of its normal operation that cause MSBuild to flag our projects as out-of-date and requiring a rebuild. By forcing those properties to match the WAP values, we can get consistent builds. One of those properties, however, is "GenerateAppxPackageOnBuild", and WAP sets it to *false*. When we set that, of course, we don't get an MSIX out of our build pipeline. Therefore, we have to break our build into two phases -- build, then package. This required us to change our approach to PCH deletion. A project without a PCH is *also* considered out-of-date. Now, we keep all PCH files but truncate them to 0 bytes. TerminalApp, however, is re-linked during packaging because the Xaml compiler emits a new generated C++ file on every build. We have to keep those PCHs around. This pull request also removes another source of build nondeterminism: that WpfTerminalControl was propagating `TargetFramework` into architecture-specific C++ builds. Its "Any CPU" platform has been removed from architecture builds at the solution level. ## PR Checklist * [ ] Closes #(none) * [x] CLA * [x] Tests added/passed/did a lot of builds * [ ] Requires documentation to be updated * [x] I've discussed this with core contributors already. ## Validation Steps Performed I ran so many freakin' builds. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:08:56 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25348