starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #3460] [MERGED] Prevents DWM crashing from also crashing us #25369

New Issue
Open
opened 2026-01-31 09:09:06 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:09:06 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/3460
Author: @zadjii-msft
Created: 11/6/2019
Status: ✅ Merged
Merged: 11/6/2019
Merged by: @miniksa

Base: master ← Head: dev/migrie/b/2735-dont-let-dwm-187-us

📝 Commits (1)

  • dcfb0c4 Prevents DWM crashing from also crashing us

📊 Changes

2 files changed (+9 additions, -6 deletions)

View changed files

📝 src/cascadia/WindowsTerminal/NonClientIslandWindow.cpp (+8 -5)
📝 src/cascadia/WindowsTerminal/NonClientIslandWindow.h (+1 -1)

📄 Description

Summary of the Pull Request

It's apparently perfectly possible that DWM will just crash or close, and when it does, DwmExtendFrameIntoClientArea will return a failure. If we THROW_IF_FAILED that call, then we'll also crash when DWM does.

This converts that THROW_IF_FAILED to a LOG_IF_FAILED. When DWM comes back, we'll hit this codepath again, and all will be right again in the world.

PR Checklist

Validation Steps Performed

taskkill /f /im dwm.exe used to crash us too, now it onlt takes down DWM.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/3460 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 11/6/2019 **Status:** ✅ Merged **Merged:** 11/6/2019 **Merged by:** [@miniksa](https://github.com/miniksa) **Base:** `master` ← **Head:** `dev/migrie/b/2735-dont-let-dwm-187-us` --- ### 📝 Commits (1) - [`dcfb0c4`](https://github.com/microsoft/terminal/commit/dcfb0c4ec88189b8c31304d6d536f8272b72e85e) Prevents DWM crashing from also crashing us ### 📊 Changes **2 files changed** (+9 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/WindowsTerminal/NonClientIslandWindow.cpp` (+8 -5) 📝 `src/cascadia/WindowsTerminal/NonClientIslandWindow.h` (+1 -1) </details> ### 📄 Description ## Summary of the Pull Request It's apparently perfectly possible that DWM will just crash or close, and when it does, `DwmExtendFrameIntoClientArea` will return a failure. If we THROW_IF_FAILED that call, then we'll also crash when DWM does. This converts that THROW_IF_FAILED to a LOG_IF_FAILED. When DWM comes back, we'll hit this codepath again, and all will be right again in the world. ## PR Checklist * [x] Closes #2735 * [x] I work here * [n/a] Tests added/passed * [n/a] Requires documentation to be updated ## Validation Steps Performed `taskkill /f /im dwm.exe` used to crash us too, now it onlt takes down DWM. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:09:06 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25369
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?