[PR #3460] Prevents DWM crashing from also crashing us #25374

Open
opened 2026-01-31 09:09:07 +00:00 by claunia · 0 comments
Owner

Original Pull Request: https://github.com/microsoft/terminal/pull/3460

State: closed
Merged: Yes


Summary of the Pull Request

It's apparently perfectly possible that DWM will just crash or close, and when it does, DwmExtendFrameIntoClientArea will return a failure. If we THROW_IF_FAILED that call, then we'll also crash when DWM does.

This converts that THROW_IF_FAILED to a LOG_IF_FAILED. When DWM comes back, we'll hit this codepath again, and all will be right again in the world.

PR Checklist

Validation Steps Performed

taskkill /f /im dwm.exe used to crash us too, now it onlt takes down DWM.

**Original Pull Request:** https://github.com/microsoft/terminal/pull/3460 **State:** closed **Merged:** Yes --- ## Summary of the Pull Request It's apparently perfectly possible that DWM will just crash or close, and when it does, `DwmExtendFrameIntoClientArea` will return a failure. If we THROW_IF_FAILED that call, then we'll also crash when DWM does. This converts that THROW_IF_FAILED to a LOG_IF_FAILED. When DWM comes back, we'll hit this codepath again, and all will be right again in the world. ## PR Checklist * [x] Closes #2735 * [x] I work here * [n/a] Tests added/passed * [n/a] Requires documentation to be updated ## Validation Steps Performed `taskkill /f /im dwm.exe` used to crash us too, now it onlt takes down DWM.
claunia added the pull-request label 2026-01-31 09:09:07 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25374