[PR #3468] [MERGED] Add experimental retro terminal effects #25382

Open
opened 2026-01-31 09:09:10 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/3468
Author: @ironyman
Created: 11/7/2019
Status: ✅ Merged
Merged: 12/12/2019
Merged by: @undefined

Base: master ← Head: shader3


📝 Commits (10+)

📊 Changes

20 files changed (+441 additions, -13 deletions)

View changed files

📝 doc/cascadia/SettingsSchema.md (+1 -0)
📝 doc/cascadia/profiles.schema.json (+4 -0)
📝 src/cascadia/PublicTerminalCore/PublicTerminalCore.vcxproj (+1 -6)
📝 src/cascadia/TerminalApp/Profile.cpp (+34 -1)
📝 src/cascadia/TerminalApp/Profile.h (+6 -0)
📝 src/cascadia/TerminalControl/TermControl.cpp (+2 -0)
📝 src/cascadia/TerminalSettings/IControlSettings.idl (+1 -0)
📝 src/cascadia/TerminalSettings/TerminalSettings.cpp (+10 -0)
📝 src/cascadia/TerminalSettings/terminalsettings.h (+5 -0)
📝 src/common.build.post.props (+1 -1)
📝 src/host/exe/Host.EXE.vcxproj (+2 -2)
📝 src/host/exe/Host.EXE.vcxproj.filters (+3 -0)
📝 src/host/ut_host/Host.UnitTests.vcxproj (+1 -1)
📝 src/interactivity/win32/ut_interactivity_win32/Interactivity.Win32.UnitTests.vcxproj (+2 -2)
📝 src/renderer/dx/DxRenderer.cpp (+237 -0)
📝 src/renderer/dx/DxRenderer.hpp (+14 -0)
➕ src/renderer/dx/ScreenPixelShader.h (+79 -0)
➕ src/renderer/dx/ScreenVertexShader.h (+16 -0)
📝 src/renderer/dx/lib/dx.vcxproj (+2 -0)
➕ src/renderer/dx/lib/dx.vcxproj.filters (+20 -0)

📄 Description

Summary of the Pull Request

Cool retro terminal effects

  • glow
  • scan lines
  • cool
  • will make terminal competitive with iterm2

References

PR Checklist

  • Closes #xxx
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

image


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/3468 **Author:** [@ironyman](https://github.com/ironyman) **Created:** 11/7/2019 **Status:** ✅ Merged **Merged:** 12/12/2019 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `shader3` --- ### 📝 Commits (10+) - [`608d6af`](https://github.com/microsoft/terminal/commit/608d6afe4a983c280826f7da19e392325518182c) Glow works - [`d74cfdc`](https://github.com/microsoft/terminal/commit/d74cfdcef433cd852e2131a48c3038f3f24fd2e0) Fix bad search and replace - [`36b4845`](https://github.com/microsoft/terminal/commit/36b484534dad4dacf8c962d75c7fedec35eac388) Blur less - [`9b7b3bc`](https://github.com/microsoft/terminal/commit/9b7b3bc055e54355325650d886aff1072117c87a) Review 1 - [`847ebff`](https://github.com/microsoft/terminal/commit/847ebff3fcf824187f0592c6095941bda92220fd) Review 1.1 - [`295e1a1`](https://github.com/microsoft/terminal/commit/295e1a1415c6dfa288f0101ef54bc8c2bf92dfb2) Review 1.2 - [`331fdc2`](https://github.com/microsoft/terminal/commit/331fdc2b8c4cd79fc43423703c3cff1cf30d4919) Lower sample count - [`eb52cab`](https://github.com/microsoft/terminal/commit/eb52cab46c90eed85a9605724dfaedca00da7830) Clean up - [`7b5673d`](https://github.com/microsoft/terminal/commit/7b5673dd79a6d4913c136e2a2b29dbeea5916abc) Add setting retroTerminalEffect - [`113a349`](https://github.com/microsoft/terminal/commit/113a349d7774c271fc61c9ff98315ae4dd83fe1a) Format files ### 📊 Changes **20 files changed** (+441 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `doc/cascadia/SettingsSchema.md` (+1 -0) 📝 `doc/cascadia/profiles.schema.json` (+4 -0) 📝 `src/cascadia/PublicTerminalCore/PublicTerminalCore.vcxproj` (+1 -6) 📝 `src/cascadia/TerminalApp/Profile.cpp` (+34 -1) 📝 `src/cascadia/TerminalApp/Profile.h` (+6 -0) 📝 `src/cascadia/TerminalControl/TermControl.cpp` (+2 -0) 📝 `src/cascadia/TerminalSettings/IControlSettings.idl` (+1 -0) 📝 `src/cascadia/TerminalSettings/TerminalSettings.cpp` (+10 -0) 📝 `src/cascadia/TerminalSettings/terminalsettings.h` (+5 -0) 📝 `src/common.build.post.props` (+1 -1) 📝 `src/host/exe/Host.EXE.vcxproj` (+2 -2) 📝 `src/host/exe/Host.EXE.vcxproj.filters` (+3 -0) 📝 `src/host/ut_host/Host.UnitTests.vcxproj` (+1 -1) 📝 `src/interactivity/win32/ut_interactivity_win32/Interactivity.Win32.UnitTests.vcxproj` (+2 -2) 📝 `src/renderer/dx/DxRenderer.cpp` (+237 -0) 📝 `src/renderer/dx/DxRenderer.hpp` (+14 -0) ➕ `src/renderer/dx/ScreenPixelShader.h` (+79 -0) ➕ `src/renderer/dx/ScreenVertexShader.h` (+16 -0) 📝 `src/renderer/dx/lib/dx.vcxproj` (+2 -0) ➕ `src/renderer/dx/lib/dx.vcxproj.filters` (+20 -0) </details> ### 📄 Description <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request Cool retro terminal effects - glow - scan lines - cool - will make terminal competitive with iterm2 <!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> ## References <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [ ] Closes #xxx * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Requires documentation to be updated * [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed ![image](https://user-images.githubusercontent.com/502496/68365644-20bda900-00e6-11ea-8a9d-0a4482e48c5a.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:09:10 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25382