[PR #3465] Break everything out of App except Xaml platform init #25384

Open
opened 2026-01-31 09:09:10 +00:00 by claunia · 0 comments
Owner

Original Pull Request: https://github.com/microsoft/terminal/pull/3465

State: closed
Merged: Yes


Summary of the Pull Request

This removes anything in App that isn't the base stuff to set up XAML. This will be necessary for dual-heading it with Centennial & UWP hosts

References

This is part of #3236 but I had to re-do it anyway because of merges. I want to get it submitted so people stop adding stuff to App.

PR Checklist

  • I work here
  • Existing tests should still pass
  • I'm a core contributor

Detailed Description of the Pull Request / Additional comments

@ocalvo tells me that app shouldn't have anything in it but just the init and onload. So I moved everything else to AppLogic and glued it back together.

Validation Steps Performed

Ran the project and launched it locally.

**Original Pull Request:** https://github.com/microsoft/terminal/pull/3465 **State:** closed **Merged:** Yes --- <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request This removes anything in App that isn't the base stuff to set up XAML. This will be necessary for dual-heading it with Centennial & UWP hosts <!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> ## References This is part of #3236 but I had to re-do it anyway because of merges. I want to get it submitted so people stop adding stuff to App. <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [x] I work here * [x] Existing tests should still pass * [x] I'm a core contributor <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments @ocalvo tells me that app shouldn't have anything in it but just the init and onload. So I moved everything else to `AppLogic` and glued it back together. <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed Ran the project and launched it locally.
claunia added the pull-request label 2026-01-31 09:09:10 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25384