starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #3489] [MERGED] replace vcpkg-cpprestsdk with a +ARM64 -ssl/boost +UWP version #25391

New Issue
Open
opened 2026-01-31 09:09:13 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:09:13 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/3489
Author: @DHowett-MSFT
Created: 11/8/2019
Status: ✅ Merged
Merged: 11/8/2019
Merged by: @DHowett-MSFT

Base: master ← Head: dev/duhowett/vcpkg_is_not_really_all_that_bad_in_the_grand_scheme_of_things_but_you_know

📝 Commits (1)

  • 5d85414 replace vcpkg-cpprestsdk with a +ARM64 -ssl/boost +UWP version

📊 Changes

6 files changed (+9 additions, -106 deletions)

View changed files

📝 build/scripts/Test-WindowsTerminalPackage.ps1 (+3 -6)
➖ src/cascadia/TerminalConnection/AzureConnection-ARM64.cpp (+0 -50)
➖ src/cascadia/TerminalConnection/AzureConnection-ARM64.h (+0 -31)
📝 src/cascadia/TerminalConnection/AzureConnection.cpp (+0 -1)
📝 src/cascadia/TerminalConnection/TerminalConnection.vcxproj (+5 -17)
📝 src/cascadia/TerminalConnection/packages.config (+1 -1)

📄 Description

This new cpprestsdk package, 2.10.14, switches us to the app CRT.
cpprestsdk turns fof a bunch of boost and openssl dependencies when it's
built for the Windows Store subplatform, so we got a bunch of stuff for
free.

Incidentally, I fixed #2338 the real/correct way -- the build rules in
the package now make sure they're not using the system vcpkg root.

PR Checklist

  • 1. Closes a bug, but not a tracked one
  • 2
  • 3
  • 4
  • 5

Validation

build/run

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/3489 **Author:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Created:** 11/8/2019 **Status:** ✅ Merged **Merged:** 11/8/2019 **Merged by:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Base:** `master` ← **Head:** `dev/duhowett/vcpkg_is_not_really_all_that_bad_in_the_grand_scheme_of_things_but_you_know` --- ### 📝 Commits (1) - [`5d85414`](https://github.com/microsoft/terminal/commit/5d85414d65c846988535c3bd6e87b2bba6c91a6e) replace vcpkg-cpprestsdk with a +ARM64 -ssl/boost +UWP version ### 📊 Changes **6 files changed** (+9 additions, -106 deletions) <details> <summary>View changed files</summary> 📝 `build/scripts/Test-WindowsTerminalPackage.ps1` (+3 -6) ➖ `src/cascadia/TerminalConnection/AzureConnection-ARM64.cpp` (+0 -50) ➖ `src/cascadia/TerminalConnection/AzureConnection-ARM64.h` (+0 -31) 📝 `src/cascadia/TerminalConnection/AzureConnection.cpp` (+0 -1) 📝 `src/cascadia/TerminalConnection/TerminalConnection.vcxproj` (+5 -17) 📝 `src/cascadia/TerminalConnection/packages.config` (+1 -1) </details> ### 📄 Description This new cpprestsdk package, 2.10.14, switches us to the app CRT. cpprestsdk turns fof a bunch of boost and openssl dependencies when it's built for the Windows Store subplatform, so we got a bunch of stuff for free. Incidentally, I fixed #2338 the real/correct way -- the build rules in the package now make sure they're not using the system vcpkg root. ## PR Checklist * [x] 1. Closes a bug, but not a tracked one * [ ] 2 * [ ] 3 * [ ] 4 * [x] 5 ## Validation build/run --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:09:13 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25391
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?