[PR #3521] [MERGED] SnapOnInput on Paste #25411

Open
opened 2026-01-31 09:09:20 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/3521
Author: @zadjii-msft
Created: 11/11/2019
Status: Merged
Merged: 11/13/2019
Merged by: @undefined

Base: masterHead: dev/migrie/b/3518-snap-on-paste


📝 Commits (1)

📊 Changes

4 files changed (+24 additions, -6 deletions)

View changed files

📝 src/cascadia/TerminalControl/TermControl.cpp (+1 -0)
📝 src/cascadia/TerminalCore/ITerminalInput.hpp (+2 -0)
📝 src/cascadia/TerminalCore/Terminal.cpp (+19 -6)
📝 src/cascadia/TerminalCore/Terminal.hpp (+2 -0)

📄 Description

Summary of the Pull Request

We forgot to snapOnInput when text is pasted. This corrects that, by making sure that pasted output attempts to snap the Terminal as well.

References

PR Checklist

  • Closes Highlighting broken on new tab (#3518)
  • I work here
  • Huh, I suppose we do have Terminal Core tests, but paste isn't really exposed through the TerminalCore, so ¯\_(ツ)_/¯
  • [n/a] Requires documentation to be updated

Validation Steps Performed

Tested manually.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/3521 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 11/11/2019 **Status:** ✅ Merged **Merged:** 11/13/2019 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `dev/migrie/b/3518-snap-on-paste` --- ### 📝 Commits (1) - [`969f810`](https://github.com/microsoft/terminal/commit/969f81000d45175b1672da6e7749c5b1bbb5ff93) Fixes #3518 ### 📊 Changes **4 files changed** (+24 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalControl/TermControl.cpp` (+1 -0) 📝 `src/cascadia/TerminalCore/ITerminalInput.hpp` (+2 -0) 📝 `src/cascadia/TerminalCore/Terminal.cpp` (+19 -6) 📝 `src/cascadia/TerminalCore/Terminal.hpp` (+2 -0) </details> ### 📄 Description ## Summary of the Pull Request We forgot to snapOnInput when text is pasted. This corrects that, by making sure that pasted output attempts to snap the Terminal as well. ## References ## PR Checklist * [x] Closes #3518 * [x] I work here * [ ] Huh, I suppose we do have Terminal Core tests, but paste isn't really exposed through the TerminalCore, so ¯\\\_(ツ)\_/¯ * [n/a] Requires documentation to be updated ## Validation Steps Performed Tested manually. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:09:20 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25411