[PR #3578] [CLOSED] Try to fix unicode layout issue #25430

Open
opened 2026-01-31 09:09:27 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/3578
Author: @skyline75489
Created: 11/14/2019
Status: ❌ Closed

Base: master ← Head: fix/unicode-lay-thehell-out


📝 Commits (3)

📊 Changes

16 files changed (+203 additions, -62 deletions)

View changed files

📝 src/buffer/out/DbcsAttribute.hpp (+24 -2)
📝 src/buffer/out/OutputCellIterator.cpp (+29 -3)
📝 src/buffer/out/OutputCellView.cpp (+8 -0)
📝 src/renderer/base/Cluster.cpp (+6 -0)
📝 src/renderer/base/renderer.cpp (+1 -1)
📝 src/renderer/dx/CustomTextLayout.cpp (+59 -6)
📝 src/renderer/dx/CustomTextLayout.h (+2 -1)
📝 src/renderer/inc/Cluster.hpp (+2 -0)
📝 src/renderer/vt/paint.cpp (+2 -2)
📝 src/types/CodepointWidthDetector.cpp (+56 -43)
📝 src/types/GlyphWidth.cpp (+5 -0)
📝 src/types/convert.cpp (+1 -1)
📝 src/types/inc/CodepointWidthDetector.hpp (+2 -1)
📝 src/types/inc/GlyphWidth.hpp (+3 -0)
📝 src/types/inc/convert.hpp (+1 -0)
📝 src/winconpty/winconpty.vcxproj (+2 -2)

📄 Description

Summary of the Pull Request

This could be the first of a series PRs intended to fix unicode layout issue.

References

#3546

PR Checklist

  • Closes #xxx
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Contrary to what @reli-msft emphasize in #3546, I found that zero length Unicode codepoint handling is the key here.

I searched a little and found https://gitlab.freedesktop.org/terminal-wg/specifications/issues/9 which refers https://github.com/ridiculousfish/widecharwidth. Then I was like, oh so there's bunch of unicode codepoint that's not included in WT currently.

Handling zero-width Unicode characters makes a lot of things weird. But here's what I got so far:

图片

Would love to hear your guys' opinion on this.

Validation Steps Performed


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/3578 **Author:** [@skyline75489](https://github.com/skyline75489) **Created:** 11/14/2019 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix/unicode-lay-thehell-out` --- ### 📝 Commits (3) - [`a62e7ce`](https://github.com/microsoft/terminal/commit/a62e7ceb7a038eaffd67a4c0bed7934c8e68d8b0) Try to fix unicode layout issue - [`68a1e17`](https://github.com/microsoft/terminal/commit/68a1e17594c7bae3698923e9c75cd4ac963f22f7) That's better - [`96ea811`](https://github.com/microsoft/terminal/commit/96ea81141b6697bfa89825d277d274849898ee20) Run cluseter ### 📊 Changes **16 files changed** (+203 additions, -62 deletions) <details> <summary>View changed files</summary> 📝 `src/buffer/out/DbcsAttribute.hpp` (+24 -2) 📝 `src/buffer/out/OutputCellIterator.cpp` (+29 -3) 📝 `src/buffer/out/OutputCellView.cpp` (+8 -0) 📝 `src/renderer/base/Cluster.cpp` (+6 -0) 📝 `src/renderer/base/renderer.cpp` (+1 -1) 📝 `src/renderer/dx/CustomTextLayout.cpp` (+59 -6) 📝 `src/renderer/dx/CustomTextLayout.h` (+2 -1) 📝 `src/renderer/inc/Cluster.hpp` (+2 -0) 📝 `src/renderer/vt/paint.cpp` (+2 -2) 📝 `src/types/CodepointWidthDetector.cpp` (+56 -43) 📝 `src/types/GlyphWidth.cpp` (+5 -0) 📝 `src/types/convert.cpp` (+1 -1) 📝 `src/types/inc/CodepointWidthDetector.hpp` (+2 -1) 📝 `src/types/inc/GlyphWidth.hpp` (+3 -0) 📝 `src/types/inc/convert.hpp` (+1 -0) 📝 `src/winconpty/winconpty.vcxproj` (+2 -2) </details> ### 📄 Description <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request This could be the first of a series PRs intended to fix unicode layout issue. <!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> ## References #3546 <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [ ] Closes #xxx * [X] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Requires documentation to be updated * [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments Contrary to what @reli-msft emphasize in #3546, I found that zero length Unicode codepoint handling is the key here. I searched a little and found https://gitlab.freedesktop.org/terminal-wg/specifications/issues/9 which refers https://github.com/ridiculousfish/widecharwidth. Then I was like, oh so there's bunch of unicode codepoint that's not included in WT currently. Handling zero-width Unicode characters makes a lot of things weird. But here's what I got so far: ![图片](https://user-images.githubusercontent.com/4710575/68852271-84f9f180-0712-11ea-9170-0d2e27d4a060.png) Would love to hear your guys' opinion on this. <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:09:27 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25430