starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #3574] [CLOSED] Rpi settings project jenny #25431

New Issue
Open
opened 2026-01-31 09:09:27 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:09:27 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/3574
Author: @JennyMLee
Created: 11/14/2019
Status: ❌ Closed

Base: master ← Head: rpi-settings-project-jenny

📝 Commits (8)

📊 Changes

27 files changed (+1519 additions, -4 deletions)

View changed files

➕ src/cascadia/TerminalApp/SettingsPage.cpp (+93 -0)
➕ src/cascadia/TerminalApp/SettingsPage.h (+41 -0)
➕ src/cascadia/TerminalApp/SettingsPage.idl (+10 -0)
➕ src/cascadia/TerminalApp/SettingsPage.xaml (+46 -0)
📝 src/cascadia/TerminalApp/TerminalPage.cpp (+3 -0)
📝 src/cascadia/TerminalApp/TerminalPage.h (+3 -0)
📝 src/cascadia/TerminalApp/TerminalPage.xaml (+4 -3)
➕ src/cascadia/TerminalApp/lib/ColorSchemesSettingsContent.cpp (+30 -0)
➕ src/cascadia/TerminalApp/lib/ColorSchemesSettingsContent.h (+23 -0)
➕ src/cascadia/TerminalApp/lib/ColorSchemesSettingsContent.idl (+9 -0)
➕ src/cascadia/TerminalApp/lib/ColorSchemesSettingsContent.xaml (+478 -0)
➕ src/cascadia/TerminalApp/lib/GlobalSettingsContent.cpp (+36 -0)
➕ src/cascadia/TerminalApp/lib/GlobalSettingsContent.h (+24 -0)
➕ src/cascadia/TerminalApp/lib/GlobalSettingsContent.idl (+9 -0)
➕ src/cascadia/TerminalApp/lib/GlobalSettingsContent.xaml (+50 -0)
➕ src/cascadia/TerminalApp/lib/GlobalsSettingsContent.cpp (+27 -0)
➕ src/cascadia/TerminalApp/lib/KeybindingsSettingsContent.cpp (+40 -0)
➕ src/cascadia/TerminalApp/lib/KeybindingsSettingsContent.h (+29 -0)
➕ src/cascadia/TerminalApp/lib/KeybindingsSettingsContent.idl (+10 -0)
➕ src/cascadia/TerminalApp/lib/KeybindingsSettingsContent.xaml (+273 -0)

...and 7 more files

📄 Description

Summary of the Pull Request

References

PR Checklist

  • Closes #xxx
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/3574 **Author:** [@JennyMLee](https://github.com/JennyMLee) **Created:** 11/14/2019 **Status:** ❌ Closed **Base:** `master` ← **Head:** `rpi-settings-project-jenny` --- ### 📝 Commits (8) - [`6a0d3a8`](https://github.com/microsoft/terminal/commit/6a0d3a8bb2355f72840f292d0970732c45d30732) basic XAML pages with navigation - [`c184b1a`](https://github.com/microsoft/terminal/commit/c184b1a35988cbeabb4781a0e0be734ab18f7c7c) code cleanup - [`6632697`](https://github.com/microsoft/terminal/commit/66326971987aa60f11cbc0cbf528069f32e31bc6) merge master (and fix) - [`bbf7027`](https://github.com/microsoft/terminal/commit/bbf70275866a4884ddf9a1765583beb6096f6cb6) Added ptr to actual settings in SettingsPage - [`ba300c3`](https://github.com/microsoft/terminal/commit/ba300c3d811392e30f4dd1b26d59c248490fcd00) jenny initial prototype - [`aacfb6a`](https://github.com/microsoft/terminal/commit/aacfb6af8477819b0cad8dfdf0adc24881e65c18) Updating the UI - [`cdcc614`](https://github.com/microsoft/terminal/commit/cdcc6148963b530cf7f277b54ba5e7cd2897f4f1) Initial binding - [`f3f8d42`](https://github.com/microsoft/terminal/commit/f3f8d4206f69a803a951230e8e6dd2046971099b) getKeybinding function update ### 📊 Changes **27 files changed** (+1519 additions, -4 deletions) <details> <summary>View changed files</summary> ➕ `src/cascadia/TerminalApp/SettingsPage.cpp` (+93 -0) ➕ `src/cascadia/TerminalApp/SettingsPage.h` (+41 -0) ➕ `src/cascadia/TerminalApp/SettingsPage.idl` (+10 -0) ➕ `src/cascadia/TerminalApp/SettingsPage.xaml` (+46 -0) 📝 `src/cascadia/TerminalApp/TerminalPage.cpp` (+3 -0) 📝 `src/cascadia/TerminalApp/TerminalPage.h` (+3 -0) 📝 `src/cascadia/TerminalApp/TerminalPage.xaml` (+4 -3) ➕ `src/cascadia/TerminalApp/lib/ColorSchemesSettingsContent.cpp` (+30 -0) ➕ `src/cascadia/TerminalApp/lib/ColorSchemesSettingsContent.h` (+23 -0) ➕ `src/cascadia/TerminalApp/lib/ColorSchemesSettingsContent.idl` (+9 -0) ➕ `src/cascadia/TerminalApp/lib/ColorSchemesSettingsContent.xaml` (+478 -0) ➕ `src/cascadia/TerminalApp/lib/GlobalSettingsContent.cpp` (+36 -0) ➕ `src/cascadia/TerminalApp/lib/GlobalSettingsContent.h` (+24 -0) ➕ `src/cascadia/TerminalApp/lib/GlobalSettingsContent.idl` (+9 -0) ➕ `src/cascadia/TerminalApp/lib/GlobalSettingsContent.xaml` (+50 -0) ➕ `src/cascadia/TerminalApp/lib/GlobalsSettingsContent.cpp` (+27 -0) ➕ `src/cascadia/TerminalApp/lib/KeybindingsSettingsContent.cpp` (+40 -0) ➕ `src/cascadia/TerminalApp/lib/KeybindingsSettingsContent.h` (+29 -0) ➕ `src/cascadia/TerminalApp/lib/KeybindingsSettingsContent.idl` (+10 -0) ➕ `src/cascadia/TerminalApp/lib/KeybindingsSettingsContent.xaml` (+273 -0) _...and 7 more files_ </details> ### 📄 Description <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request <!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> ## References <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [ ] Closes #xxx * [ ] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Requires documentation to be updated * [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:09:27 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25431
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?