[PR #3618] [MERGED] Re-add keybindings to new tab dropdown #25450

Open
opened 2026-01-31 09:09:36 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/3618
Author: @zadjii-msft
Created: 11/18/2019
Status: Merged
Merged: 11/21/2019
Merged by: @zadjii-msft

Base: masterHead: dev/migrie/b/3603-new-tab-dd-regression


📝 Commits (3)

  • e5db9b9 fixes #3603 by searching for ActionAndArgs too
  • 1ea0727 Apply suggestions from code review
  • cd01a85 Merge branch 'master' into dev/migrie/b/3603-new-tab-dd-regression

📊 Changes

7 files changed (+104 additions, -9 deletions)

View changed files

📝 src/cascadia/TerminalApp/ActionArgs.h (+54 -0)
📝 src/cascadia/TerminalApp/ActionArgs.idl (+4 -3)
📝 src/cascadia/TerminalApp/AppKeyBindings.cpp (+24 -1)
📝 src/cascadia/TerminalApp/AppKeyBindings.h (+2 -1)
📝 src/cascadia/TerminalApp/AppKeyBindings.idl (+2 -1)
📝 src/cascadia/TerminalApp/AppKeyBindingsSerialization.cpp (+1 -1)
📝 src/cascadia/TerminalApp/TerminalPage.cpp (+17 -2)

📄 Description

Summary of the Pull Request

With #3391, I almost certainly regressed the ability for the new tab dropdown to display the keybindings for each profile. This adds them back.

PR Checklist

Detailed Description of the Pull Request / Additional comments

Now, we can lookup keybindings not only for ShortcutActions, but also ActionAndArgss, so we can look up the binding for an action with a particular set of arguments.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/3618 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 11/18/2019 **Status:** ✅ Merged **Merged:** 11/21/2019 **Merged by:** [@zadjii-msft](https://github.com/zadjii-msft) **Base:** `master` ← **Head:** `dev/migrie/b/3603-new-tab-dd-regression` --- ### 📝 Commits (3) - [`e5db9b9`](https://github.com/microsoft/terminal/commit/e5db9b974e9c6be28df4747c8685aef26606dff4) fixes #3603 by searching for ActionAndArgs too - [`1ea0727`](https://github.com/microsoft/terminal/commit/1ea072765cf5ea87370a0707be1c679d4efdbe4f) Apply suggestions from code review - [`cd01a85`](https://github.com/microsoft/terminal/commit/cd01a85385401a40d28d2d1a252bae4d769ff7db) Merge branch 'master' into dev/migrie/b/3603-new-tab-dd-regression ### 📊 Changes **7 files changed** (+104 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/ActionArgs.h` (+54 -0) 📝 `src/cascadia/TerminalApp/ActionArgs.idl` (+4 -3) 📝 `src/cascadia/TerminalApp/AppKeyBindings.cpp` (+24 -1) 📝 `src/cascadia/TerminalApp/AppKeyBindings.h` (+2 -1) 📝 `src/cascadia/TerminalApp/AppKeyBindings.idl` (+2 -1) 📝 `src/cascadia/TerminalApp/AppKeyBindingsSerialization.cpp` (+1 -1) 📝 `src/cascadia/TerminalApp/TerminalPage.cpp` (+17 -2) </details> ### 📄 Description ## Summary of the Pull Request With #3391, I almost certainly regressed the ability for the new tab dropdown to display the keybindings for each profile. This adds them back. ## PR Checklist * [x] Closes #3603 * [x] I work here * [ ] Tests added/passed * [n/a] Requires documentation to be updated ## Detailed Description of the Pull Request / Additional comments Now, we can lookup keybindings not only for `ShortcutAction`s, but also `ActionAndArgs`s, so we can look up the binding for an action with a particular set of arguments. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:09:36 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25450