starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #3629] [MERGED] Fixing increase + decrease font size #25452

New Issue
Open
opened 2026-01-31 09:09:37 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:09:37 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/3629
Author: @leonMSFT
Created: 11/19/2019
Status: ✅ Merged
Merged: 11/20/2019
Merged by: @zadjii-msft

Base: master ← Head: dev/lelian/incdecfontnoworky

📝 Commits (6)

  • b13f74c adding FromJson to AdjustFontSizeArgs
  • 8b0bf0b made a legacy function that just allows you to do 1/-1 delta for adjusting font size
  • 93a04c3 adding test case
  • 4f19641 removing extra quotes
  • 48873a6 comments lmao
  • a00876e FORMATTING WHY

📊 Changes

3 files changed (+64 additions, -2 deletions)

View changed files

📝 src/cascadia/LocalTests_TerminalApp/KeyBindingsTests.cpp (+29 -2)
📝 src/cascadia/TerminalApp/ActionArgs.h (+14 -0)
📝 src/cascadia/TerminalApp/AppKeyBindingsSerialization.cpp (+21 -0)

📄 Description

Summary of the Pull Request

Fixes #3604 where Increase/Decrease font size bindings were not working.

PR Checklist

Validation Steps Performed

Increase and decrease font size works once again!

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/3629 **Author:** [@leonMSFT](https://github.com/leonMSFT) **Created:** 11/19/2019 **Status:** ✅ Merged **Merged:** 11/20/2019 **Merged by:** [@zadjii-msft](https://github.com/zadjii-msft) **Base:** `master` ← **Head:** `dev/lelian/incdecfontnoworky` --- ### 📝 Commits (6) - [`b13f74c`](https://github.com/microsoft/terminal/commit/b13f74ca0b459726a45902f895cb70b9978f7a7f) adding FromJson to AdjustFontSizeArgs - [`8b0bf0b`](https://github.com/microsoft/terminal/commit/8b0bf0b7af4ecf28bbd265bc9d27d8542b444a76) made a legacy function that just allows you to do 1/-1 delta for adjusting font size - [`93a04c3`](https://github.com/microsoft/terminal/commit/93a04c3f1796acb69e8efc3cd5ab1093653dab15) adding test case - [`4f19641`](https://github.com/microsoft/terminal/commit/4f196413f835c92c3f7bbefae515be4474bf0595) removing extra quotes - [`48873a6`](https://github.com/microsoft/terminal/commit/48873a616ccc24062d0159604c4cd716e660f7d9) comments lmao - [`a00876e`](https://github.com/microsoft/terminal/commit/a00876e0bb93841a7726d69f63d51616a07d2ec5) FORMATTING WHY ### 📊 Changes **3 files changed** (+64 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/LocalTests_TerminalApp/KeyBindingsTests.cpp` (+29 -2) 📝 `src/cascadia/TerminalApp/ActionArgs.h` (+14 -0) 📝 `src/cascadia/TerminalApp/AppKeyBindingsSerialization.cpp` (+21 -0) </details> ### 📄 Description <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request Fixes #3604 where Increase/Decrease font size bindings were not working. <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [x] Closes #3604 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed Increase and decrease font size works once again! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:09:37 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25452
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?