[PR #3681] [MERGED] doc: Disambiguate "Keybindings" reference; add example keys #25470

Open
opened 2026-01-31 09:09:43 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/3681
Author: @ragerdl
Created: 11/23/2019
Status: Merged
Merged: 12/4/2019
Merged by: @DHowett-MSFT

Base: masterHead: dev/ragerdl/add-keybinding-examples


📝 Commits (4)

  • c4aa6f7 Disambiguate "Keybindings" reference; add a few example keys
  • af5ca0f Update doc/cascadia/SettingsSchema.md
  • 8c1ebf0 Update doc/cascadia/SettingsSchema.md
  • 7bb6df2 Update doc/cascadia/SettingsSchema.md

📊 Changes

1 file changed (+11 additions, -2 deletions)

View changed files

📝 doc/cascadia/SettingsSchema.md (+11 -2)

📄 Description

Summary of the Pull Request

It took me some trial and error to figure out how to bind "ctrl+pgdn". This patch adds a small amount of documentation for that key combination and a couple others (both of which I tested).

Since I was here anyway, I suspect the use of the word "keybinding" was unintentional, as the thing it refers to is later referred to as a "command". So, I tidied that up.

Tested by visual inspection.

References

None

PR Checklist

  • [N/A] Closes #xxx
  • [CHECK] CLA signed. If not, go over here and sign the CLA
  • [N/A] Tests added/passed
  • [N/A] Requires documentation to be updated
  • [READY] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

N/A

Validation Steps Performed

Validated by manual inspection.

Comments

The new terminal (combined with WSL) is a welcome improvement that makes developing on Windows about 5x easier. I am also glad to learn that I can customize the keybindings, as I am an avid emacs user. Thanks for all your efforts!


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/3681 **Author:** [@ragerdl](https://github.com/ragerdl) **Created:** 11/23/2019 **Status:** ✅ Merged **Merged:** 12/4/2019 **Merged by:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Base:** `master` ← **Head:** `dev/ragerdl/add-keybinding-examples` --- ### 📝 Commits (4) - [`c4aa6f7`](https://github.com/microsoft/terminal/commit/c4aa6f76fdc9b933b1cdabd6ee9ad4842e1fa58e) Disambiguate "Keybindings" reference; add a few example keys - [`af5ca0f`](https://github.com/microsoft/terminal/commit/af5ca0fe7d3fbddc50597287c32b1f29d3e5f745) Update doc/cascadia/SettingsSchema.md - [`8c1ebf0`](https://github.com/microsoft/terminal/commit/8c1ebf0ae7de434e684a929ff423cc3f757ec301) Update doc/cascadia/SettingsSchema.md - [`7bb6df2`](https://github.com/microsoft/terminal/commit/7bb6df28f171001cc4814f5f3be5791511bbe355) Update doc/cascadia/SettingsSchema.md ### 📊 Changes **1 file changed** (+11 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `doc/cascadia/SettingsSchema.md` (+11 -2) </details> ### 📄 Description <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request It took me some trial and error to figure out how to bind "ctrl+pgdn". This patch adds a small amount of documentation for that key combination and a couple others (both of which I tested). Since I was here anyway, I suspect the use of the word "keybinding" was unintentional, as the thing it refers to is later referred to as a "command". So, I tidied that up. Tested by visual inspection. <!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> ## References None <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [N/A] Closes #xxx * [CHECK] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [N/A] Tests added/passed * [N/A] Requires documentation to be updated * [READY] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments N/A <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed Validated by manual inspection. ## Comments The new terminal (combined with WSL) is a welcome improvement that makes developing on Windows about 5x easier. I am also glad to learn that I can customize the keybindings, as I am an avid emacs user. Thanks for all your efforts! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:09:43 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25470