starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #3672] [MERGED] consolidate PackageES versioning in /custom.props #25472

New Issue
Open
opened 2026-01-31 09:09:44 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:09:44 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/3672
Author: @DHowett-MSFT
Created: 11/23/2019
Status: ✅ Merged
Merged: 11/25/2019
Merged by: @DHowett-MSFT

Base: master ← Head: dev/duhowett/csproj

📝 Commits (5)

  • d705b6f Conform to some arcane rules regarding project files
  • 0325da2 Revert "Conform to some arcane rules regarding project files"
  • 52cd772 Pop the version into something
  • 4df60c7 wing it
  • 25363f5 x

📊 Changes

3 files changed (+12 additions, -6 deletions)

View changed files

➕ custom.props (+11 -0)
📝 src/cascadia/CascadiaPackage/CascadiaPackage.wapproj (+0 -5)
📝 src/cascadia/WpfTerminalControl/WpfTerminalControl.csproj (+1 -1)

📄 Description

This location and name is practically mandated by PackageES. Sorry ☹️.

This will ensure that all artifacts that we produce are versioned properly:

thing version (example)
exe, dll, .net assembly 0.7.1911.22009
nupkg 0.7.191122009
appx 0.7.3269.0

For reference, here's the version format:

EXE, DLL, .NET Assembly

0.7.1911.22009
^ ^  ^ ^  ^  ^
| |  | |  |  `-Build # on that date
| |  | |  `-Day
| |  | `-Month
| |  `-Year
| `-Minor
`-Major

NuGet Package

0.7.191122009
^ ^  ^ ^ ^  ^
| |  | | |  `-Build # on that date
| |  | | `-Day
| |  | `-Month
| |  `-Year
| `-Minor
`-Major

AppX Package

0.7.03269.0
^ ^ ^  ^^ ^
| | |  || `-Contractually always zero (a waste)
| | |  |`-Build # on that date
| | |  `-Number of days in [base year]
| | `-Number of years since [base year]
| `-Minor
`-Major

[base year] = $(XesBaseYearForStoreVersion)

It is expected that the base year is changed every time
the version number is changed.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/3672 **Author:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Created:** 11/23/2019 **Status:** ✅ Merged **Merged:** 11/25/2019 **Merged by:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Base:** `master` ← **Head:** `dev/duhowett/csproj` --- ### 📝 Commits (5) - [`d705b6f`](https://github.com/microsoft/terminal/commit/d705b6fa6ab9c492073103b17eed56c08420f5a6) Conform to some arcane rules regarding project files - [`0325da2`](https://github.com/microsoft/terminal/commit/0325da2715b3f03dbff1ff6e79f56e1e2685c877) Revert "Conform to some arcane rules regarding project files" - [`52cd772`](https://github.com/microsoft/terminal/commit/52cd772def63de5c73dc01d27e686846ad278121) Pop the version into something - [`4df60c7`](https://github.com/microsoft/terminal/commit/4df60c78c15535b89bbf69a113ed4d41a38827e1) wing it - [`25363f5`](https://github.com/microsoft/terminal/commit/25363f5a3c0cf7a8683f371f9b12efc2911a6400) x ### 📊 Changes **3 files changed** (+12 additions, -6 deletions) <details> <summary>View changed files</summary> ➕ `custom.props` (+11 -0) 📝 `src/cascadia/CascadiaPackage/CascadiaPackage.wapproj` (+0 -5) 📝 `src/cascadia/WpfTerminalControl/WpfTerminalControl.csproj` (+1 -1) </details> ### 📄 Description This location and name is practically mandated by PackageES. Sorry ☹️. This will ensure that all artifacts that we produce are versioned properly: |thing|version (example)| |-|-| |exe, dll, .net assembly|`0.7.1911.22009`| |nupkg|`0.7.191122009`| |appx|`0.7.3269.0`| For reference, here's the version format: ### EXE, DLL, .NET Assembly ``` 0.7.1911.22009 ^ ^ ^ ^ ^ ^ | | | | | `-Build # on that date | | | | `-Day | | | `-Month | | `-Year | `-Minor `-Major ``` ### NuGet Package ``` 0.7.191122009 ^ ^ ^ ^ ^ ^ | | | | | `-Build # on that date | | | | `-Day | | | `-Month | | `-Year | `-Minor `-Major ``` ### AppX Package ``` 0.7.03269.0 ^ ^ ^ ^^ ^ | | | || `-Contractually always zero (a waste) | | | |`-Build # on that date | | | `-Number of days in [base year] | | `-Number of years since [base year] | `-Minor `-Major [base year] = $(XesBaseYearForStoreVersion) ``` It is expected that the base year is changed every time the version number is changed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:09:44 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25472
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?