[PR #3752] [CLOSED] Enable changing the color of the active pane border #25490

Open
opened 2026-01-31 09:09:50 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/3752
Author: @zadjii-msft
Created: 11/27/2019
Status: Closed

Base: masterHead: dev/migrie/f/3061-pane-accent-color


📝 Commits (1)

  • eb87e62 Enable changing the color of the active pane border

📊 Changes

12 files changed (+223 additions, -23 deletions)

View changed files

📝 doc/cascadia/profiles.schema.json (+11 -0)
📝 src/cascadia/TerminalApp/AppLogic.cpp (+3 -2)
📝 src/cascadia/TerminalApp/CascadiaSettings.cpp (+50 -0)
📝 src/cascadia/TerminalApp/CascadiaSettings.h (+2 -0)
📝 src/cascadia/TerminalApp/GlobalAppSettings.cpp (+55 -0)
📝 src/cascadia/TerminalApp/GlobalAppSettings.h (+6 -1)
📝 src/cascadia/TerminalApp/Pane.cpp (+50 -17)
📝 src/cascadia/TerminalApp/Resources/en-US/Resources.resw (+4 -0)
📝 src/cascadia/TerminalApp/TerminalWarnings.h (+2 -1)
📝 src/cascadia/TerminalApp/defaults.json (+1 -0)
📝 src/types/inc/utils.hpp (+2 -1)
📝 src/types/utils.cpp (+37 -1)

📄 Description

Summary of the Pull Request

Adds a new setting, "activePaneBorderColor", which lets the user change the color of the active pane border. This setting can have 3 values:

  • null: to clear the active pane border color (and have no color there)
  • "accent": to use the accent color
  • a color string in format "#RRGGBB", to use that color

If it's not one of those values, it will display a warning, and default to null.

PR Checklist


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/3752 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 11/27/2019 **Status:** ❌ Closed **Base:** `master` ← **Head:** `dev/migrie/f/3061-pane-accent-color` --- ### 📝 Commits (1) - [`eb87e62`](https://github.com/microsoft/terminal/commit/eb87e62d1c0395a667ea3aed688ce69de19923e8) Enable changing the color of the active pane border ### 📊 Changes **12 files changed** (+223 additions, -23 deletions) <details> <summary>View changed files</summary> 📝 `doc/cascadia/profiles.schema.json` (+11 -0) 📝 `src/cascadia/TerminalApp/AppLogic.cpp` (+3 -2) 📝 `src/cascadia/TerminalApp/CascadiaSettings.cpp` (+50 -0) 📝 `src/cascadia/TerminalApp/CascadiaSettings.h` (+2 -0) 📝 `src/cascadia/TerminalApp/GlobalAppSettings.cpp` (+55 -0) 📝 `src/cascadia/TerminalApp/GlobalAppSettings.h` (+6 -1) 📝 `src/cascadia/TerminalApp/Pane.cpp` (+50 -17) 📝 `src/cascadia/TerminalApp/Resources/en-US/Resources.resw` (+4 -0) 📝 `src/cascadia/TerminalApp/TerminalWarnings.h` (+2 -1) 📝 `src/cascadia/TerminalApp/defaults.json` (+1 -0) 📝 `src/types/inc/utils.hpp` (+2 -1) 📝 `src/types/utils.cpp` (+37 -1) </details> ### 📄 Description <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request Adds a new setting, `"activePaneBorderColor"`, which lets the user change the color of the active pane border. This setting can have 3 values: - `null`: to clear the active pane border color (and have no color there) - `"accent"`: to use the accent color - a color string in format `"#RRGGBB"`, to use that color If it's not one of those values, it will display a warning, and default to `null`. ## PR Checklist * [x] Closes #3061 * [x] I work here * [ ] Tests added/passed * [x] Requires documentation to be updated --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:09:50 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25490