[PR #3722] [MERGED] Add a 'splitPane' ShortcutAction #25491

Open
opened 2026-01-31 09:09:50 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/3722
Author: @zadjii-msft
Created: 11/26/2019
Status: Merged
Merged: 11/28/2019
Merged by: @zadjii-msft

Base: masterHead: dev/migrie/f/splitPane-action


📝 Commits (7)

  • 9474240 Add a 'splitPane' keybinding that can be used for splitting a pane either vertically or horizontally
  • fb93105 Update documentation too
  • 451aaab Good lord this is important
  • 31a9046 Add a test too, though I have no idea if it works
  • b5a264b "style" -> "split"
  • e0cd014 pr comments from carlos
  • de60a30 Merge remote-tracking branch 'origin/master' into dev/migrie/f/splitPane-action

📊 Changes

17 files changed (+246 additions, -80 deletions)

View changed files

📝 doc/cascadia/SettingsSchema.md (+1 -2)
📝 doc/cascadia/profiles.schema.json (+26 -0)
📝 src/cascadia/LocalTests_TerminalApp/KeyBindingsTests.cpp (+91 -0)
📝 src/cascadia/TerminalApp/ActionArgs.cpp (+1 -0)
📝 src/cascadia/TerminalApp/ActionArgs.h (+48 -0)
📝 src/cascadia/TerminalApp/ActionArgs.idl (+11 -0)
📝 src/cascadia/TerminalApp/AppActionHandlers.cpp (+11 -11)
📝 src/cascadia/TerminalApp/AppKeyBindingsSerialization.cpp (+29 -2)
📝 src/cascadia/TerminalApp/Pane.h (+11 -18)
📝 src/cascadia/TerminalApp/ShortcutActionDispatch.cpp (+2 -5)
📝 src/cascadia/TerminalApp/ShortcutActionDispatch.h (+1 -2)
📝 src/cascadia/TerminalApp/ShortcutActionDispatch.idl (+2 -2)
📝 src/cascadia/TerminalApp/Tab.cpp (+2 -2)
📝 src/cascadia/TerminalApp/Tab.h (+2 -2)
📝 src/cascadia/TerminalApp/TerminalPage.cpp (+4 -27)
📝 src/cascadia/TerminalApp/TerminalPage.h (+2 -5)
📝 src/cascadia/TerminalApp/defaults.json (+2 -2)

📄 Description

Summary of the Pull Request

We already have "splitHorizontal" and "splitVertical", but those will both be deprecated in favor of "splitPane" with arguments.

Currently, there's one argument: "style", which is one of "vertical" or "horizontal."

References

This is being done in pursuit of supporting #607 and #998. I don't really want to lob #998 in with this one, since both that and this are hefty enough PRs even as they are. (I have a branch for #998, but it needs this first)

This will probably conflict with #3658

PR Checklist

  • Doesn't actually close anything, only enables #998
  • I work here
  • Tests added/passed - yea okay no excuses here
  • Requires documentation to be updated

Validation Steps Performed

Added new keybindings with the args - works
Tried the old keybindings without the args - still works


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/3722 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 11/26/2019 **Status:** ✅ Merged **Merged:** 11/28/2019 **Merged by:** [@zadjii-msft](https://github.com/zadjii-msft) **Base:** `master` ← **Head:** `dev/migrie/f/splitPane-action` --- ### 📝 Commits (7) - [`9474240`](https://github.com/microsoft/terminal/commit/9474240cbb382f7e0ef5b43b42ce70b8969b2ce0) Add a 'splitPane' keybinding that can be used for splitting a pane either vertically or horizontally - [`fb93105`](https://github.com/microsoft/terminal/commit/fb93105c7f4d94adab6552b73bc9c25e861d66b5) Update documentation too - [`451aaab`](https://github.com/microsoft/terminal/commit/451aaabcb68cb3f99232cf50664956bcbce96706) Good lord this is important - [`31a9046`](https://github.com/microsoft/terminal/commit/31a9046defccdb6e2e18e3fb0df62546beab2abc) Add a test too, though I have no idea if it works - [`b5a264b`](https://github.com/microsoft/terminal/commit/b5a264b4caba6a77f22d8501b9be1933aeccdc8e) "style" -> "split" - [`e0cd014`](https://github.com/microsoft/terminal/commit/e0cd0148e3b6bdcc5f068b58232b593d94211273) pr comments from carlos - [`de60a30`](https://github.com/microsoft/terminal/commit/de60a3048f732c786ba5fd09ff3119e9c9b0d9cf) Merge remote-tracking branch 'origin/master' into dev/migrie/f/splitPane-action ### 📊 Changes **17 files changed** (+246 additions, -80 deletions) <details> <summary>View changed files</summary> 📝 `doc/cascadia/SettingsSchema.md` (+1 -2) 📝 `doc/cascadia/profiles.schema.json` (+26 -0) 📝 `src/cascadia/LocalTests_TerminalApp/KeyBindingsTests.cpp` (+91 -0) 📝 `src/cascadia/TerminalApp/ActionArgs.cpp` (+1 -0) 📝 `src/cascadia/TerminalApp/ActionArgs.h` (+48 -0) 📝 `src/cascadia/TerminalApp/ActionArgs.idl` (+11 -0) 📝 `src/cascadia/TerminalApp/AppActionHandlers.cpp` (+11 -11) 📝 `src/cascadia/TerminalApp/AppKeyBindingsSerialization.cpp` (+29 -2) 📝 `src/cascadia/TerminalApp/Pane.h` (+11 -18) 📝 `src/cascadia/TerminalApp/ShortcutActionDispatch.cpp` (+2 -5) 📝 `src/cascadia/TerminalApp/ShortcutActionDispatch.h` (+1 -2) 📝 `src/cascadia/TerminalApp/ShortcutActionDispatch.idl` (+2 -2) 📝 `src/cascadia/TerminalApp/Tab.cpp` (+2 -2) 📝 `src/cascadia/TerminalApp/Tab.h` (+2 -2) 📝 `src/cascadia/TerminalApp/TerminalPage.cpp` (+4 -27) 📝 `src/cascadia/TerminalApp/TerminalPage.h` (+2 -5) 📝 `src/cascadia/TerminalApp/defaults.json` (+2 -2) </details> ### 📄 Description ## Summary of the Pull Request We already have "splitHorizontal" and "splitVertical", but those will both be deprecated in favor of "splitPane" with arguments. Currently, there's one argument: "style", which is one of "vertical" or "horizontal." ## References This is being done in pursuit of supporting #607 and #998. I don't really want to lob #998 in with this one, since both that and this are hefty enough PRs even as they are. (I have a branch for #998, but it needs this first) This will probably conflict with #3658 ## PR Checklist * [ ] Doesn't actually close anything, only enables #998 * [x] I work here * [ ] Tests added/passed - yea okay no excuses here * [x] Requires documentation to be updated ## Validation Steps Performed Added new keybindings with the args - works Tried the old keybindings without the args - still works --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:09:50 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25491