[PR #3807] [MERGED] Fix LocalTests that were working before #25508

Open
opened 2026-01-31 09:09:58 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/3807
Author: @zadjii-msft
Created: 12/2/2019
Status: ✅ Merged
Merged: 12/3/2019
Merged by: @undefined

Base: master ← Head: dev/migrie/3536-fix-localtests


📝 Commits (3)

  • 3be37fd I this restores the functionality of the local winrt objects, not XAML
  • 8a0bb8d Fix the unit tests, add comments
  • 1760de2 That's what I get for not building before pushing

📊 Changes

6 files changed (+92 additions, -101 deletions)

View changed files

📝 src/cascadia/LocalTests_TerminalApp/ColorSchemeTests.cpp (+7 -8)
📝 src/cascadia/LocalTests_TerminalApp/KeyBindingsTests.cpp (+43 -33)
📝 src/cascadia/LocalTests_TerminalApp/ProfileTests.cpp (+7 -8)
📝 src/cascadia/LocalTests_TerminalApp/SettingsTests.cpp (+7 -8)
📝 src/cascadia/LocalTests_TerminalApp/TabTests.cpp (+16 -31)
📝 src/cascadia/LocalTests_TerminalApp/TerminalApp.LocalTests.AppxManifest.prototype.xml (+12 -13)

📄 Description

Summary of the Pull Request

Fixes the LocalTests that should work. This does not fix the TabTests.

PR Checklist

Detailed Description of the Pull Request / Additional comments

In a previous PR, we broke unpackaged activation. This had the unintended side-effect of breaking these tests. The solution here is to run these unittests packaged.

This also makes things a little bit better for the TabTests, but doesn't fix them (inexplicably). A mail thread internally is tracking the progress of fixing those tests.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/3807 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 12/2/2019 **Status:** ✅ Merged **Merged:** 12/3/2019 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `dev/migrie/3536-fix-localtests` --- ### 📝 Commits (3) - [`3be37fd`](https://github.com/microsoft/terminal/commit/3be37fd89a54ac858a9f44d297a55d9e9b5af562) I this restores the functionality of the local winrt objects, not XAML - [`8a0bb8d`](https://github.com/microsoft/terminal/commit/8a0bb8d003afbf746907209ff3db333318336814) Fix the unit tests, add comments - [`1760de2`](https://github.com/microsoft/terminal/commit/1760de2c54bba2a57be3c15af7e9ee4a53be64a2) That's what I get for not building before pushing ### 📊 Changes **6 files changed** (+92 additions, -101 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/LocalTests_TerminalApp/ColorSchemeTests.cpp` (+7 -8) 📝 `src/cascadia/LocalTests_TerminalApp/KeyBindingsTests.cpp` (+43 -33) 📝 `src/cascadia/LocalTests_TerminalApp/ProfileTests.cpp` (+7 -8) 📝 `src/cascadia/LocalTests_TerminalApp/SettingsTests.cpp` (+7 -8) 📝 `src/cascadia/LocalTests_TerminalApp/TabTests.cpp` (+16 -31) 📝 `src/cascadia/LocalTests_TerminalApp/TerminalApp.LocalTests.AppxManifest.prototype.xml` (+12 -13) </details> ### 📄 Description ## Summary of the Pull Request Fixes the LocalTests that should work. This does _not_ fix the TabTests. ## PR Checklist * [x] Closes #3536 * [x] I work here * [x] This is literally making the tests work * [n/a] Requires documentation to be updated ## Detailed Description of the Pull Request / Additional comments In a previous PR, we broke unpackaged activation. This had the unintended side-effect of breaking these tests. The solution here is to run these unittests _packaged_. This also makes things a little bit better for the TabTests, but doesn't fix them (inexplicably). A mail thread internally is tracking the progress of fixing those tests. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:09:58 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25508