starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #3811] [CLOSED] Bugfix: correct copy vs copyTextWithoutNewlines behavior #25509

New Issue
Open
opened 2026-01-31 09:09:58 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:09:58 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/3811
Author: @carlos-zamora
Created: 12/2/2019
Status: ❌ Closed

Base: master ← Head: dev/cazamor/bugfix-copy-kb

📝 Commits (3)

  • bcedd48 Bugfix: correct copy vs copyTextWithoutNewlines behavior
  • b787599 wrong var name in schema
  • 45be187 changed name of arg and reversed logic

📊 Changes

9 files changed (+29 additions, -31 deletions)

View changed files

📝 doc/cascadia/profiles.schema.json (+2 -2)
📝 src/cascadia/LocalTests_TerminalApp/KeyBindingsTests.cpp (+10 -10)
📝 src/cascadia/TerminalApp/ActionArgs.h (+5 -5)
📝 src/cascadia/TerminalApp/ActionArgs.idl (+1 -1)
📝 src/cascadia/TerminalApp/AppActionHandlers.cpp (+1 -1)
📝 src/cascadia/TerminalApp/AppKeyBindingsSerialization.cpp (+1 -1)
📝 src/cascadia/TerminalApp/TerminalPage.cpp (+3 -4)
📝 src/cascadia/TerminalControl/TermControl.cpp (+5 -6)
📝 src/cascadia/TerminalControl/TermControl.h (+1 -1)

📄 Description

Summary of the Pull Request

Corrected behavior for (de)serialization. Changed variable name for clarification.

References

N/A

PR Checklist

  • Closes Cannot type chinese characters. (#3782)
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

This was on me. Should've caught it in the code review. Sorry!

Validation Steps Performed

Tests
And personal tests

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/3811 **Author:** [@carlos-zamora](https://github.com/carlos-zamora) **Created:** 12/2/2019 **Status:** ❌ Closed **Base:** `master` ← **Head:** `dev/cazamor/bugfix-copy-kb` --- ### 📝 Commits (3) - [`bcedd48`](https://github.com/microsoft/terminal/commit/bcedd481f12533c79f07ecd9d96303896388ab19) Bugfix: correct copy vs copyTextWithoutNewlines behavior - [`b787599`](https://github.com/microsoft/terminal/commit/b787599cc49ca4c29cd84ffe301aa4b7b462b9c2) wrong var name in schema - [`45be187`](https://github.com/microsoft/terminal/commit/45be1876ae336d222ff53d8727cc9be0f3f6877c) changed name of arg and reversed logic ### 📊 Changes **9 files changed** (+29 additions, -31 deletions) <details> <summary>View changed files</summary> 📝 `doc/cascadia/profiles.schema.json` (+2 -2) 📝 `src/cascadia/LocalTests_TerminalApp/KeyBindingsTests.cpp` (+10 -10) 📝 `src/cascadia/TerminalApp/ActionArgs.h` (+5 -5) 📝 `src/cascadia/TerminalApp/ActionArgs.idl` (+1 -1) 📝 `src/cascadia/TerminalApp/AppActionHandlers.cpp` (+1 -1) 📝 `src/cascadia/TerminalApp/AppKeyBindingsSerialization.cpp` (+1 -1) 📝 `src/cascadia/TerminalApp/TerminalPage.cpp` (+3 -4) 📝 `src/cascadia/TerminalControl/TermControl.cpp` (+5 -6) 📝 `src/cascadia/TerminalControl/TermControl.h` (+1 -1) </details> ### 📄 Description ## Summary of the Pull Request Corrected behavior for (de)serialization. Changed variable name for clarification. ## References N/A ## PR Checklist * [ ] Closes #3782 * [ ] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Requires documentation to be updated * [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx ## Detailed Description of the Pull Request / Additional comments This was on me. Should've caught it in the code review. Sorry! ## Validation Steps Performed Tests And personal tests --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:09:58 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25509
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?