[PR #3823] [MERGED] Correct Copy Keybinding Arg Default Behavior #25518

Open
opened 2026-01-31 09:10:02 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/3823
Author: @carlos-zamora
Created: 12/3/2019
Status: Merged
Merged: 12/4/2019
Merged by: @DHowett-MSFT

Base: masterHead: dev/cazamor/bugfix-copy-arg-kb


📝 Commits (2)

  • 4062322 Correct Copy Keybinding Arg Default Behavior
  • bdd0ac8 updated schema

📊 Changes

4 files changed (+10 additions, -10 deletions)

View changed files

📝 doc/cascadia/profiles.schema.json (+2 -2)
📝 src/cascadia/LocalTests_TerminalApp/KeyBindingsTests.cpp (+6 -6)
📝 src/cascadia/TerminalApp/ActionArgs.h (+1 -1)
📝 src/cascadia/TerminalApp/AppKeyBindingsSerialization.cpp (+1 -1)

📄 Description

Summary of the Pull Request

Correct behavior for copyTextWithoutNewlines. Updated schema for clarity.

References

Abandoned #3811

PR Checklist


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/3823 **Author:** [@carlos-zamora](https://github.com/carlos-zamora) **Created:** 12/3/2019 **Status:** ✅ Merged **Merged:** 12/4/2019 **Merged by:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Base:** `master` ← **Head:** `dev/cazamor/bugfix-copy-arg-kb` --- ### 📝 Commits (2) - [`4062322`](https://github.com/microsoft/terminal/commit/4062322cbbe7c7b8862289def19a0257f135c6f4) Correct Copy Keybinding Arg Default Behavior - [`bdd0ac8`](https://github.com/microsoft/terminal/commit/bdd0ac812455a0f948d15108364c0b71f9af3ad2) updated schema ### 📊 Changes **4 files changed** (+10 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `doc/cascadia/profiles.schema.json` (+2 -2) 📝 `src/cascadia/LocalTests_TerminalApp/KeyBindingsTests.cpp` (+6 -6) 📝 `src/cascadia/TerminalApp/ActionArgs.h` (+1 -1) 📝 `src/cascadia/TerminalApp/AppKeyBindingsSerialization.cpp` (+1 -1) </details> ### 📄 Description ## Summary of the Pull Request Correct behavior for `copyTextWithoutNewlines`. Updated schema for clarity. ## References Abandoned #3811 ## PR Checklist * [x] Closes #3782 * [ ] CLA signed. * [ ] Tests added/passed * [ ] Requires documentation to be updated --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:10:02 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25518