[PR #3901] [MERGED] Fix a crash when opening a new tab with args #25538

Open
opened 2026-01-31 09:10:11 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/3901
Author: @zadjii-msft
Created: 12/10/2019
Status: ✅ Merged
Merged: 12/11/2019
Merged by: @undefined

Base: master ← Head: dev/migrie/b/3897-fix-logging-crash


📝 Commits (1)

📊 Changes

2 files changed (+27 additions, -25 deletions)

View changed files

📝 src/cascadia/TerminalApp/TerminalPage.cpp (+26 -24)
📝 src/cascadia/TerminalApp/TerminalPage.h (+1 -1)

📄 Description

Summary of the Pull Request

I accidentally did the wrong check here to see if the value exists. For an IReference, you need to do variable != nullptr. I did variable.Value().

References

Introduced in #3825

PR Checklist

Detailed Description of the Pull Request / Additional comments

This includes a maybe unrelated fix to make TerminalPage's ShortcutActionDispatch a com_ptr. While I was messing with the tests for this, I caught that we're not supposed to direct allocate winrt types like that. Ofc, the TerminalAppLib project doesn't catch this.

Validation Steps Performed

Ran the terminal manually, instead of just running the tests


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/3901 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 12/10/2019 **Status:** ✅ Merged **Merged:** 12/11/2019 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `dev/migrie/b/3897-fix-logging-crash` --- ### 📝 Commits (1) - [`0e9fbf1`](https://github.com/microsoft/terminal/commit/0e9fbf1dfc524688ffb54bb9b4fa51d5d760a773) This is the bugfix for #3897 ### 📊 Changes **2 files changed** (+27 additions, -25 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/TerminalPage.cpp` (+26 -24) 📝 `src/cascadia/TerminalApp/TerminalPage.h` (+1 -1) </details> ### 📄 Description ## Summary of the Pull Request I accidentally did the wrong check here to see if the value exists. For an `IReference`, you need to do `variable != nullptr`. I did `variable.Value()`. ## References Introduced in #3825 ## PR Checklist * [x] Closes #3897 * [x] I work here * [ ] Tests added/passed - wow this was a lot harder than I expected * [n/a] Requires documentation to be updated ## Detailed Description of the Pull Request / Additional comments This includes a maybe unrelated fix to make `TerminalPage`'s `ShortcutActionDispatch` a `com_ptr`. While I was messing with the tests for this, I caught that we're not supposed to direct allocate winrt types like that. Ofc, the `TerminalAppLib` project doesn't catch this. ## Validation Steps Performed Ran the terminal manually, instead of just running the tests --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:10:11 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25538