[PR #3872] [MERGED] Initialize the selectionBackground to a D2D1_COLOR_F #25539

Open
opened 2026-01-31 09:10:11 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/3872
Author: @zadjii-msft
Created: 12/6/2019
Status: ✅ Merged
Merged: 12/6/2019
Merged by: @undefined

Base: master ← Head: dev/migrie/b/3861-colorref-2-d2d1


📝 Commits (1)

  • 24c08e9 I think this fixes this but I honestly don't know how to test the WPF control

📊 Changes

1 file changed (+5 additions, -1 deletions)

View changed files

📝 src/renderer/dx/DxRenderer.cpp (+5 -1)

📄 Description

Summary of the Pull Request

I believe this fixes #3861 but I honestly don't know how to test that part of the code. Just from reading the issue description that @dhowett-msft provided.

References

PR Checklist

Validation Steps Performed

Really none, I just built it and :fingers_crossed:


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/3872 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 12/6/2019 **Status:** ✅ Merged **Merged:** 12/6/2019 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `dev/migrie/b/3861-colorref-2-d2d1` --- ### 📝 Commits (1) - [`24c08e9`](https://github.com/microsoft/terminal/commit/24c08e97c6e0d0efca31fba6075fc65bb42f94e2) I think this fixes this but I honestly don't know how to test the WPF control ### 📊 Changes **1 file changed** (+5 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/renderer/dx/DxRenderer.cpp` (+5 -1) </details> ### 📄 Description ## Summary of the Pull Request I believe this fixes #3861 but I honestly don't know how to test that part of the code. Just from reading the issue description that @dhowett-msft provided. ## References ## PR Checklist * [x] Closes #3861 * [x] I work here * [ ] Are there tests for this? * [n/a] Requires documentation to be updated ## Validation Steps Performed Really none, I just built it and :fingers_crossed: --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:10:11 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25539