[PR #4022] [MERGED] Fix a crash when dragging a debug conhost across a DPI boundary #25601

Open
opened 2026-01-31 09:10:33 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/4022
Author: @zadjii-msft
Created: 12/19/2019
Status: Merged
Merged: 1/2/2020
Merged by: @undefined

Base: masterHead: dev/migrie/b/4012-conhost-explodes-oftem


📝 Commits (1)

  • d126df4 Fix a crash when dragging a debug conhost across a DPI boundary

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 src/interactivity/win32/windowproc.cpp (+1 -1)

📄 Description

Summary of the Pull Request

When dragging DEBUG conhost across a DPI boundary, we'd crash. This doesn't repro for some reason on Release builds. Maybe @miniksa can share some light why that is.

PR Checklist

Validation Steps Performed

Dragged it across the boundary again, doesn't crash anymore 🙏


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/4022 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 12/19/2019 **Status:** ✅ Merged **Merged:** 1/2/2020 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `dev/migrie/b/4012-conhost-explodes-oftem` --- ### 📝 Commits (1) - [`d126df4`](https://github.com/microsoft/terminal/commit/d126df4082136048cf6075a27c0ce4477d2fdfa6) Fix a crash when dragging a debug conhost across a DPI boundary ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/interactivity/win32/windowproc.cpp` (+1 -1) </details> ### 📄 Description ## Summary of the Pull Request When dragging _DEBUG_ conhost across a DPI boundary, we'd crash. This doesn't repro for some reason on Release builds. Maybe @miniksa can share some light why that is. ## PR Checklist * [x] Closes #4012 * [x] I work here * [ ] Tests added/passed * [n/a] Requires documentation to be updated ## Validation Steps Performed Dragged it across the boundary again, doesn't crash anymore 🙏 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:10:33 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25601