[PR #4025] [MERGED] Add support for "Automatic" splits #25609

Open
opened 2026-01-31 09:10:36 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/4025
Author: @zadjii-msft
Created: 12/19/2019
Status: Merged
Merged: 12/19/2019
Merged by: @undefined

Base: masterHead: dev/migrie/f/3960-auto-split


📝 Commits (2)

  • 81f08c9 Add support for "Automatic" splits
  • cd61228 some minor nits from code review

📊 Changes

5 files changed (+71 additions, -5 deletions)

View changed files

📝 src/cascadia/LocalTests_TerminalApp/KeyBindingsTests.cpp (+22 -2)
📝 src/cascadia/TerminalApp/ActionArgs.h (+5 -0)
📝 src/cascadia/TerminalApp/ActionArgs.idl (+1 -0)
📝 src/cascadia/TerminalApp/Pane.cpp (+42 -3)
📝 src/cascadia/TerminalApp/Pane.h (+1 -0)

📄 Description

Summary of the Pull Request

Adds support for auto as a potential value for a splitPane keybinding's split argument. For example:

        { "keys": [ "ctrl+shift+z" ], "command": { "action": "splitPane", "profile": "matrix", "commandline": "cmd.exe", "split":"auto" } },

When set to auto, Panes will decide which direction to split based on the available space within the terminal. If the pane is wider than it is tall, the pane will introduce a new vertical split (and vice-versa).

References

PR Checklist

Validation Steps Performed

Ran tests, played with it.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/4025 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 12/19/2019 **Status:** ✅ Merged **Merged:** 12/19/2019 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `dev/migrie/f/3960-auto-split` --- ### 📝 Commits (2) - [`81f08c9`](https://github.com/microsoft/terminal/commit/81f08c99e0a1fd360819891e9b29f004bb67dd87) Add support for "Automatic" splits - [`cd61228`](https://github.com/microsoft/terminal/commit/cd6122848ef05d9ec075c05965bb06b5bd01b866) some minor nits from code review ### 📊 Changes **5 files changed** (+71 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/LocalTests_TerminalApp/KeyBindingsTests.cpp` (+22 -2) 📝 `src/cascadia/TerminalApp/ActionArgs.h` (+5 -0) 📝 `src/cascadia/TerminalApp/ActionArgs.idl` (+1 -0) 📝 `src/cascadia/TerminalApp/Pane.cpp` (+42 -3) 📝 `src/cascadia/TerminalApp/Pane.h` (+1 -0) </details> ### 📄 Description ## Summary of the Pull Request Adds support for `auto` as a potential value for a `splitPane` keybinding's `split` argument. For example: ```json { "keys": [ "ctrl+shift+z" ], "command": { "action": "splitPane", "profile": "matrix", "commandline": "cmd.exe", "split":"auto" } }, ``` When set to `auto`, Panes will decide which direction to split based on the available space within the terminal. If the pane is wider than it is tall, the pane will introduce a new vertical split (and vice-versa). ## References ## PR Checklist * [x] Closes #3960 * [x] I work here * [x] Tests added/passed * [n/a] Requires documentation to be updated ## Validation Steps Performed Ran tests, played with it. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:10:36 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25609