starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #4101] [MERGED] No more are you sure boxes #25630

New Issue
Open
opened 2026-01-31 09:10:44 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:10:44 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/4101
Author: @rstat1
Created: 1/2/2020
Status: ✅ Merged
Merged: 1/31/2020
Merged by: @undefined

Base: master ← Head: no-are-you-sure-boxes

📝 Commits (10+)

  • 19b9811 Add option+checkbox to disable the "Do you want close all tabs?" dialog.
  • 37aad17 The word "Confirm" has an "R" in it. faceplam
  • 4854dce Fix formating. Remove "confirmCloseAllTabs" from userDefaults.json.
  • 392f30d One more time: "Fix formatting".
  • 2387830 Whitespace begone!
  • 012b1e0 Merge master.
  • 874766a Merge branch 'master' into no-are-you-sure-boxes
  • 5043bbf Revert "Merge branch 'master' into no-are-you-sure-boxes"
  • 5adbfa4 Merge branch 'master' into no-are-you-sure-boxes
  • 68c7698 Update profile schema file and docs with new setting.

📊 Changes

6 files changed (+28 additions, -1 deletions)

View changed files

📝 doc/cascadia/SettingsSchema.md (+1 -0)
📝 doc/cascadia/profiles.schema.json (+5 -0)
📝 src/cascadia/TerminalApp/GlobalAppSettings.cpp (+16 -0)
📝 src/cascadia/TerminalApp/GlobalAppSettings.h (+4 -0)
📝 src/cascadia/TerminalApp/TerminalPage.cpp (+1 -1)
📝 src/cascadia/TerminalApp/defaults.json (+1 -0)

📄 Description

Summary of the Pull Request

So this PR adds a profile setting called "confirmCloseAllTabs", that allows one to enable or disable the "Do you want close all tabs?" dialog that appears when you close a window with multiple open tabs. It current defaults to "true". Also adds a checkbox to that dialog that also sets "confirmCloseAllTabs"

References

PR Checklist

  • Closes Tab name too long (#3883)
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

I added a checkbox to the close dialog to set this setting, but I'm not sure how to best go about actually changing the setting from code; am open to suggestions, as to how it should be done, or if I should also just remove it and stick with the profile setting.

Validation Steps Performed

  1. Set "confirmCloseAllTabs" to false in my profile.json file.
  2. Opened a 2nd tab.
  3. Closed the window
  4. Observed that there was no confirmation before the window closed.
  5. Set "confirmCloseAllTabs" to true
  6. Repeat steps 2 and 3
  7. Observe that there was a confirmation before the window closed.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/4101 **Author:** [@rstat1](https://github.com/rstat1) **Created:** 1/2/2020 **Status:** ✅ Merged **Merged:** 1/31/2020 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `no-are-you-sure-boxes` --- ### 📝 Commits (10+) - [`19b9811`](https://github.com/microsoft/terminal/commit/19b98117535ba3595f1afe87d0cab9580c0330d1) Add option+checkbox to disable the "Do you want close all tabs?" dialog. - [`37aad17`](https://github.com/microsoft/terminal/commit/37aad175fdc1394046a20a62545cc7d6647044a3) The word "Confirm" has an "R" in it. *faceplam* - [`4854dce`](https://github.com/microsoft/terminal/commit/4854dce4e003795a32d791cec0dc6dd8b987af8d) Fix formating. Remove "confirmCloseAllTabs" from userDefaults.json. - [`392f30d`](https://github.com/microsoft/terminal/commit/392f30d63184f7e417169aee8dd639eb2bca7da4) One more time: "Fix formatting". - [`2387830`](https://github.com/microsoft/terminal/commit/2387830491a0c1cfa710ffd885062726f804612f) Whitespace begone! - [`012b1e0`](https://github.com/microsoft/terminal/commit/012b1e0d88d4482de55cd3281db6d3bb2b271584) Merge master. - [`874766a`](https://github.com/microsoft/terminal/commit/874766a7d7fa4c8bb276cf445a76a90c633a0ce2) Merge branch 'master' into no-are-you-sure-boxes - [`5043bbf`](https://github.com/microsoft/terminal/commit/5043bbf6af867777bfcaf5c306fb1af3d3638578) Revert "Merge branch 'master' into no-are-you-sure-boxes" - [`5adbfa4`](https://github.com/microsoft/terminal/commit/5adbfa449e9ae84cace31ed0667e17d80c9201d0) Merge branch 'master' into no-are-you-sure-boxes - [`68c7698`](https://github.com/microsoft/terminal/commit/68c769814236676042baec5da97fd70039e58457) Update profile schema file and docs with new setting. ### 📊 Changes **6 files changed** (+28 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `doc/cascadia/SettingsSchema.md` (+1 -0) 📝 `doc/cascadia/profiles.schema.json` (+5 -0) 📝 `src/cascadia/TerminalApp/GlobalAppSettings.cpp` (+16 -0) 📝 `src/cascadia/TerminalApp/GlobalAppSettings.h` (+4 -0) 📝 `src/cascadia/TerminalApp/TerminalPage.cpp` (+1 -1) 📝 `src/cascadia/TerminalApp/defaults.json` (+1 -0) </details> ### 📄 Description <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request So this PR adds a profile setting called "confirmCloseAllTabs", that allows one to enable or disable the "Do you want close all tabs?" dialog that appears when you close a window with multiple open tabs. It current defaults to "true". Also adds a checkbox to that dialog that also sets "confirmCloseAllTabs" <!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> ## References <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [x] Closes #3883 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Requires documentation to be updated * [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments I added a checkbox to the close dialog to set this setting, but I'm not sure how to best go about actually changing the setting from code; am open to suggestions, as to how it should be done, or if I should also just remove it and stick with the profile setting. <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed 1. Set "confirmCloseAllTabs" to false in my profile.json file. 2. Opened a 2nd tab. 3. Closed the window 4. Observed that there was no confirmation before the window closed. 5. Set "confirmCloseAllTabs" to true 6. Repeat steps 2 and 3 7. Observe that there was a confirmation before the window closed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:10:44 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25630
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?