[PR #4108] [MERGED] add til::color, a universal-converting color type #25638

Open
opened 2026-01-31 09:10:49 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/4108
Author: @DHowett-MSFT
Created: 1/3/2020
Status: ✅ Merged
Merged: 3/10/2020
Merged by: @undefined

Base: master ← Head: dev/duhowett/tilcolor


📝 Commits (6)

  • a3122fe add til::color, a universal-converting color type
  • 7264139 til: pass static analysis
  • d3de507 til::color::operator==
  • 3dcf0e1 til::color: add tests
  • 4ca6835 Merge remote-tracking branch 'origin/master' into dev/duhowett/tilcolor
  • 1535a90 why not do the MG thing?

📊 Changes

7 files changed (+230 additions, -0 deletions)

View changed files

📝 src/inc/LibraryIncludes.h (+2 -0)
📝 src/inc/til.h (+1 -0)
➕ src/inc/til/color.h (+117 -0)
➕ src/til/ut_til/ColorTests.cpp (+104 -0)
📝 src/til/ut_til/sources (+1 -0)
📝 src/til/ut_til/til.unit.tests.vcxproj (+1 -0)
📝 tools/ConsoleTypes.natvis (+4 -0)

📄 Description

til::color will help us move away from COLORREF internally. It supports
conversion to/from COLORREF, and from all types of structs containing
members named R, G, B and A (or r, g, b, and a).

Validation Steps Performed

Tests; run through profile/colorScheme deserialization with til::color
instead of uint32_t or COLORREF.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/4108 **Author:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Created:** 1/3/2020 **Status:** ✅ Merged **Merged:** 3/10/2020 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `dev/duhowett/tilcolor` --- ### 📝 Commits (6) - [`a3122fe`](https://github.com/microsoft/terminal/commit/a3122fec23575be27ed2858f5b2c9a1c0c4d8b78) add til::color, a universal-converting color type - [`7264139`](https://github.com/microsoft/terminal/commit/7264139ef1bd87859395c36395f290c66ad90327) til: pass static analysis - [`d3de507`](https://github.com/microsoft/terminal/commit/d3de5076432cb0e3636abb63da73871b6270ab6e) til::color::operator== - [`3dcf0e1`](https://github.com/microsoft/terminal/commit/3dcf0e15aa7630da1c3f4c73bdbbac5b02580fdd) til::color: add tests - [`4ca6835`](https://github.com/microsoft/terminal/commit/4ca6835c3431ebb5ee5b2a8ddb43406f5e5f308d) Merge remote-tracking branch 'origin/master' into dev/duhowett/tilcolor - [`1535a90`](https://github.com/microsoft/terminal/commit/1535a90db57d0929744eae20dbea13cfe01dcb21) why not do the MG thing? ### 📊 Changes **7 files changed** (+230 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/inc/LibraryIncludes.h` (+2 -0) 📝 `src/inc/til.h` (+1 -0) ➕ `src/inc/til/color.h` (+117 -0) ➕ `src/til/ut_til/ColorTests.cpp` (+104 -0) 📝 `src/til/ut_til/sources` (+1 -0) 📝 `src/til/ut_til/til.unit.tests.vcxproj` (+1 -0) 📝 `tools/ConsoleTypes.natvis` (+4 -0) </details> ### 📄 Description til::color will help us move away from COLORREF internally. It supports conversion to/from COLORREF, and from all types of structs containing members named R, G, B and A (or r, g, b, and a). ## Validation Steps Performed Tests; run through profile/colorScheme deserialization with `til::color` instead of `uint32_t` or `COLORREF`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:10:49 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25638