starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #4140] [MERGED] Fix IME/CoreTextEditContext not being reset properly #25650

New Issue
Open
opened 2026-01-31 09:10:53 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:10:53 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/4140
Author: @lhecker
Created: 1/7/2020
Status: ✅ Merged
Merged: 1/8/2020
Merged by: @undefined

Base: master ← Head: fix-ime

📝 Commits (1)

  • dfa7b4a Fix IME/CoreTextEditContext not being reset properly

📊 Changes

1 file changed (+4 additions, -11 deletions)

View changed files

📝 src/cascadia/TerminalControl/TSFInputControl.cpp (+4 -11)

📄 Description

The first argument to NotifyTextChanged incorrectly was [0,0]
instead of the length of the text to be removed from the
CoreTextEditContext.

Best source of documentation for NotifyTextChanged:
https://docs.microsoft.com/en-us/windows/uwp/design/input/custom-text-input#overriding-text-updates

FYI @DHowett-MSFT (just in case): C++/WinRT uses winrt::param::hstring
for string parameters which intelligently borrows strings. As such you
can simply pass a std::wstring to most WinRT methods without the need
of having to allocate an intermediate hstring. 🙂

Validation Steps Performed

I followed the reproduction instructions of #3706 and #3745 and ensured
the issue doesn't happen anymore.

Closes #3645
Closes #3706
Closes #3745

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/4140 **Author:** [@lhecker](https://github.com/lhecker) **Created:** 1/7/2020 **Status:** ✅ Merged **Merged:** 1/8/2020 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `fix-ime` --- ### 📝 Commits (1) - [`dfa7b4a`](https://github.com/microsoft/terminal/commit/dfa7b4a16c7a8f6a2d4b6337dcf524d3c6f017ba) Fix IME/CoreTextEditContext not being reset properly ### 📊 Changes **1 file changed** (+4 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalControl/TSFInputControl.cpp` (+4 -11) </details> ### 📄 Description The first argument to `NotifyTextChanged` incorrectly was `[0,0]` instead of the length of the text to be removed from the `CoreTextEditContext`. Best source of documentation for `NotifyTextChanged`: https://docs.microsoft.com/en-us/windows/uwp/design/input/custom-text-input#overriding-text-updates FYI @DHowett-MSFT (just in case): C++/WinRT uses `winrt::param::hstring` for string parameters which intelligently borrows strings. As such you can simply pass a `std::wstring` to most WinRT methods without the need of having to allocate an intermediate `hstring`. 🙂 ## Validation Steps Performed I followed the reproduction instructions of #3706 and #3745 and ensured the issue doesn't happen anymore. Closes #3645 Closes #3706 Closes #3745 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:10:53 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25650
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?