[PR #4143] [MERGED] Fix a test that regressed during #3575 #25652

Open
opened 2026-01-31 09:10:53 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/4143
Author: @zadjii-msft
Created: 1/7/2020
Status: Merged
Merged: 1/7/2020
Merged by: @DHowett-MSFT

Base: masterHead: dev/migrie/b/4137-fix-broken-test


📝 Commits (1)

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 src/cascadia/LocalTests_TerminalApp/SettingsTests.cpp (+2 -2)

📄 Description

Summary of the Pull Request

Fix a test that regressed during #3575. It wasn't caught, because the LocalTests don't run in CI unfortunately.

PR Checklist

Validation Steps Performed

Ran the local tests


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/4143 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 1/7/2020 **Status:** ✅ Merged **Merged:** 1/7/2020 **Merged by:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Base:** `master` ← **Head:** `dev/migrie/b/4137-fix-broken-test` --- ### 📝 Commits (1) - [`3af27ad`](https://github.com/microsoft/terminal/commit/3af27ad85140eb3467a38cc74520bdae81460b38) fix the test ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/LocalTests_TerminalApp/SettingsTests.cpp` (+2 -2) </details> ### 📄 Description ## Summary of the Pull Request Fix a test that regressed during #3575. It wasn't caught, because the LocalTests don't run in CI unfortunately. ## PR Checklist * [x] Closes #4137 * [x] I work here * [x] Tests added/passed * [n/a] Requires documentation to be updated ## Validation Steps Performed Ran the local tests --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:10:53 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25652