starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #4173] [MERGED] Remove global namespaced min/max and replace it with STL min/max #25670

New Issue
Open
opened 2026-01-31 09:11:00 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:11:00 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/4173
Author: @skyline75489
Created: 1/10/2020
Status: ✅ Merged
Merged: 1/10/2020
Merged by: @undefined

Base: master ← Head: fix/nominmax-1

📝 Commits (1)

  • 568fa97 Remove global namespaced min/max and replace it with STL min/max

📊 Changes

10 files changed (+34 additions, -30 deletions)

View changed files

📝 src/host/ft_host/API_BufferTests.cpp (+1 -1)
📝 src/host/ft_host/API_DimensionsTests.cpp (+1 -1)
📝 src/host/ft_host/API_OutputTests.cpp (+16 -16)
📝 src/host/ft_host/API_TitleTests.cpp (+1 -1)
📝 src/host/ft_host/CJK_DbcsTests.cpp (+1 -1)
📝 src/host/ft_host/precomp.h (+2 -0)
📝 src/propsheet/console.cpp (+7 -7)
📝 src/propsheet/fontdlg.cpp (+1 -1)
📝 src/propsheet/precomp.h (+2 -0)
📝 src/propsheet/preview.cpp (+2 -2)

📄 Description

Summary of the Pull Request

It's 2020 now. It's about time that we move on from 1990's macros.

References

PR Checklist

  • Closes Typo in READ.md (#4152)
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Remove global namespaced min/max and replace it with STL min/max.

Validation Steps Performed

Run it.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/4173 **Author:** [@skyline75489](https://github.com/skyline75489) **Created:** 1/10/2020 **Status:** ✅ Merged **Merged:** 1/10/2020 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `fix/nominmax-1` --- ### 📝 Commits (1) - [`568fa97`](https://github.com/microsoft/terminal/commit/568fa971b64dbb7e7f64f2aaa68ce3224a63030b) Remove global namespaced min/max and replace it with STL min/max ### 📊 Changes **10 files changed** (+34 additions, -30 deletions) <details> <summary>View changed files</summary> 📝 `src/host/ft_host/API_BufferTests.cpp` (+1 -1) 📝 `src/host/ft_host/API_DimensionsTests.cpp` (+1 -1) 📝 `src/host/ft_host/API_OutputTests.cpp` (+16 -16) 📝 `src/host/ft_host/API_TitleTests.cpp` (+1 -1) 📝 `src/host/ft_host/CJK_DbcsTests.cpp` (+1 -1) 📝 `src/host/ft_host/precomp.h` (+2 -0) 📝 `src/propsheet/console.cpp` (+7 -7) 📝 `src/propsheet/fontdlg.cpp` (+1 -1) 📝 `src/propsheet/precomp.h` (+2 -0) 📝 `src/propsheet/preview.cpp` (+2 -2) </details> ### 📄 Description <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request It's 2020 now. It's *about* time that we move on from 1990's macros. <!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> ## References <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [X] Closes #4152 * [X] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Requires documentation to be updated * [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments Remove global namespaced min/max and replace it with STL min/max. <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed Run it. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:11:00 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25670
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?