starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #4222] [MERGED] Added initialPosition and launchMode to settings schema #25688

New Issue
Open
opened 2026-01-31 09:11:09 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:11:09 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/4222
Author: @cinnamon-msft
Created: 1/14/2020
Status: ✅ Merged
Merged: 1/28/2020
Merged by: @cinnamon-msft

Base: master ← Head: cinnamon/settings-schema-initial-position

📝 Commits (8)

  • e0e7bac added initialPosition and launchMode to schema
  • afd3a6d regex works
  • aa7b5b1 fixed regex bug
  • c938784 remove lookaround
  • f447a36 Update doc/cascadia/profiles.schema.json
  • 0612a46 update description in settingsschema.md
  • 75fd28f edit descriptions to have code markings
  • a79b704 remove code backticks from schema

📊 Changes

2 files changed (+21 additions, -2 deletions)

View changed files

📝 doc/cascadia/SettingsSchema.md (+2 -0)
📝 doc/cascadia/profiles.schema.json (+19 -2)

📄 Description

Summary of the Pull Request

Added initialPosition and launchMode to settings json schema and md file

References

PR Checklist

  • Closes Paste size warnings (#3290)
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/4222 **Author:** [@cinnamon-msft](https://github.com/cinnamon-msft) **Created:** 1/14/2020 **Status:** ✅ Merged **Merged:** 1/28/2020 **Merged by:** [@cinnamon-msft](https://github.com/cinnamon-msft) **Base:** `master` ← **Head:** `cinnamon/settings-schema-initial-position` --- ### 📝 Commits (8) - [`e0e7bac`](https://github.com/microsoft/terminal/commit/e0e7bac6d98058a9682e69e105e8066ca82cd29a) added initialPosition and launchMode to schema - [`afd3a6d`](https://github.com/microsoft/terminal/commit/afd3a6d85f67b265e402a5e89da353227d871894) regex works - [`aa7b5b1`](https://github.com/microsoft/terminal/commit/aa7b5b1032269917bbe7cc917d28d073aa3c31e5) fixed regex bug - [`c938784`](https://github.com/microsoft/terminal/commit/c938784a8d8133a98e7313c76ebc7c1aeef13768) remove lookaround - [`f447a36`](https://github.com/microsoft/terminal/commit/f447a36930bfe9756f3d9a393e7d7ba35bbe2cc1) Update doc/cascadia/profiles.schema.json - [`0612a46`](https://github.com/microsoft/terminal/commit/0612a46d6a6c06e69aac9d9f679dd21343fa9516) update description in settingsschema.md - [`75fd28f`](https://github.com/microsoft/terminal/commit/75fd28f3a5de2f8eaf2707eb0ac7544eeb9edbb9) edit descriptions to have code markings - [`a79b704`](https://github.com/microsoft/terminal/commit/a79b7044aeef92218ad539cb710f4bdb7020edc3) remove code backticks from schema ### 📊 Changes **2 files changed** (+21 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `doc/cascadia/SettingsSchema.md` (+2 -0) 📝 `doc/cascadia/profiles.schema.json` (+19 -2) </details> ### 📄 Description <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request Added initialPosition and launchMode to settings json schema and md file <!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> ## References <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [x] Closes #3290 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Requires documentation to be updated * [x] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:11:09 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25688
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?