[PR #4219] [MERGED] Add find action to keybinding commands in Settings Profile Schema #25689

Open
opened 2026-01-31 09:11:09 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/4219
Author: @Harmon758
Created: 1/14/2020
Status: ✅ Merged
Merged: 1/14/2020
Merged by: @carlos-zamora

Base: master ← Head: find-schema-addition


📝 Commits (1)

  • c352da6 Add find action to keybinding commands in Settings Profile Schema

📊 Changes

1 file changed (+2 additions, -1 deletions)

View changed files

📝 doc/cascadia/profiles.schema.json (+2 -1)

📄 Description

Summary of the Pull Request

Add find as a ShortcutActionName, so that it is recognized as a command for keybindings in profiles.json settings.

References

This seems to have been missed by #3590.

PR Checklist

  • Closes Split screen with tmux makes font smaller (#4218)
  • CLA signed
  • [N/A] Tests added/passed
  • [N/A] Requires documentation to be updated
  • [N/A] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

See #4218

Validation Steps Performed

The command is recognized when using the updated schema:

image


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/4219 **Author:** [@Harmon758](https://github.com/Harmon758) **Created:** 1/14/2020 **Status:** ✅ Merged **Merged:** 1/14/2020 **Merged by:** [@carlos-zamora](https://github.com/carlos-zamora) **Base:** `master` ← **Head:** `find-schema-addition` --- ### 📝 Commits (1) - [`c352da6`](https://github.com/microsoft/terminal/commit/c352da60dc34935e12bcfc35bea4d40b5f1fe4ed) Add find action to keybinding commands in Settings Profile Schema ### 📊 Changes **1 file changed** (+2 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `doc/cascadia/profiles.schema.json` (+2 -1) </details> ### 📄 Description ## Summary of the Pull Request Add `find` as a `ShortcutActionName`, so that it is recognized as a command for keybindings in profiles.json settings. ## References This seems to have been missed by #3590. ## PR Checklist * [X] Closes #4218 * [X] CLA signed * [N/A] Tests added/passed * [N/A] Requires documentation to be updated * [N/A] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments See #4218 ## Validation Steps Performed The command is recognized when using the updated schema: ![image](https://user-images.githubusercontent.com/9403740/72377075-b708df00-36d4-11ea-9fc2-07822f90606f.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:11:09 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25689