[PR #4278] [CLOSED] Introduce til namespaces shorthands for the chromium safe math #25699

Open
opened 2026-01-31 09:11:12 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/4278
Author: @skyline75489
Created: 1/17/2020
Status: ❌ Closed

Base: master ← Head: fix/til-safe-math


📝 Commits (1)

  • 5cd06ff Introduce til namespaces shorthands for the chromium safe math

📊 Changes

3 files changed (+29 additions, -0 deletions)

View changed files

📝 src/inc/LibraryIncludes.h (+3 -0)
📝 src/inc/til.h (+1 -0)
➕ src/inc/til/numeric.h (+25 -0)

📄 Description

Summary of the Pull Request

This does not work yet.

References

PR Checklist

  • Closes #xxx
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/4278 **Author:** [@skyline75489](https://github.com/skyline75489) **Created:** 1/17/2020 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix/til-safe-math` --- ### 📝 Commits (1) - [`5cd06ff`](https://github.com/microsoft/terminal/commit/5cd06ff08e0d1a880fe630514a59481ed63891f1) Introduce `til` namespaces shorthands for the chromium safe math ### 📊 Changes **3 files changed** (+29 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/inc/LibraryIncludes.h` (+3 -0) 📝 `src/inc/til.h` (+1 -0) ➕ `src/inc/til/numeric.h` (+25 -0) </details> ### 📄 Description <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request This does not work yet. <!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> ## References <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [ ] Closes #xxx * [ ] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Requires documentation to be updated * [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:11:12 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25699