starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #4249] [MERGED] schema: add support for "auto" split value #25700

New Issue
Open
opened 2026-01-31 09:11:12 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:11:12 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/4249
Author: @mkitzan
Created: 1/15/2020
Status: ✅ Merged
Merged: 1/15/2020
Merged by: @DHowett-MSFT

Base: master ← Head: splitpane-schema-update

📝 Commits (2)

  • 41eff1c Add support for "auto" split
  • 3d853cb Added auto description and made auto default

📊 Changes

1 file changed (+4 additions, -3 deletions)

View changed files

📝 doc/cascadia/profiles.schema.json (+4 -3)

📄 Description

Summary of the Pull Request

profiles.schema.json did not have auto as a valid value for the split attribute. This PR adds the support and makes a minor update to the details associated with the split attribute.

References

PR Checklist

  • Closes Regression in line wrapping from #2924 (#4245)
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated :: PR technically updates docs
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #4245

Detailed Description of the Pull Request / Additional comments

Potentially the default value for SplitPaneAction should be set to auto as well. Let me know your thoughts.

Validation Steps Performed

Changed the $schema attribute in my local profiles.json to the updated profiles.schema.json and ensured that auto did not have a squiggly line like in #4245.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/4249 **Author:** [@mkitzan](https://github.com/mkitzan) **Created:** 1/15/2020 **Status:** ✅ Merged **Merged:** 1/15/2020 **Merged by:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Base:** `master` ← **Head:** `splitpane-schema-update` --- ### 📝 Commits (2) - [`41eff1c`](https://github.com/microsoft/terminal/commit/41eff1c9461fa3a2286d2e5a7bb0fc00056f2af2) Add support for "auto" split - [`3d853cb`](https://github.com/microsoft/terminal/commit/3d853cb398ec8d9f62fc716bc9f2f8bd9e42aa1d) Added auto description and made auto default ### 📊 Changes **1 file changed** (+4 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `doc/cascadia/profiles.schema.json` (+4 -3) </details> ### 📄 Description <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request `profiles.schema.json` did not have `auto` as a valid value for the `split` attribute. This PR adds the support and makes a minor update to the details associated with the `split` attribute. <!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> ## References <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [x] Closes #4245 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [x] Requires documentation to be updated :: PR technically updates docs * [x] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #4245 <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments Potentially the [`default`](https://github.com/microsoft/terminal/blob/master/doc/cascadia/profiles.schema.json#L217) value for `SplitPaneAction` should be set to `auto` as well. Let me know your thoughts. <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed Changed the `$schema` attribute in my local `profiles.json` to the updated `profiles.schema.json` and ensured that `auto` did not have a squiggly line like in #4245. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:11:12 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25700
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?