[PR #4319] [MERGED] Fix the UnitTests_TerminalCore's dependency on RendererGdi #25706

Open
opened 2026-01-31 09:11:15 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/4319
Author: @zadjii-msft
Created: 1/21/2020
Status: Merged
Merged: 1/22/2020
Merged by: @undefined

Base: masterHead: dev/migrie/b/fix-build-gdi


📝 Commits (2)

  • 490f205 I think this should fix the build
  • 3d31771 Also this project needs to be built first (VS YOU KNOW THIS)

📊 Changes

2 files changed (+6 additions, -0 deletions)

View changed files

📝 OpenConsole.sln (+3 -0)
📝 src/cascadia/UnitTests_TerminalCore/UnitTests.vcxproj (+3 -0)

📄 Description

Summary of the Pull Request

In #4213 I added a dependency to the UnitTests_TerminalCore project on basically all of conhost. This worked on my machine, but it's consistently not working on other machines. This should fix those issues.

References

PR Checklist

Validation Steps Performed

Made a fresh clone and built it.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/4319 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 1/21/2020 **Status:** ✅ Merged **Merged:** 1/22/2020 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `dev/migrie/b/fix-build-gdi` --- ### 📝 Commits (2) - [`490f205`](https://github.com/microsoft/terminal/commit/490f205867891080550189ff6896c12cd1a4ebf8) I think this should fix the build - [`3d31771`](https://github.com/microsoft/terminal/commit/3d31771581aa794ebea27c92f16713d95c086222) Also this project needs to be built first (VS YOU KNOW THIS) ### 📊 Changes **2 files changed** (+6 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `OpenConsole.sln` (+3 -0) 📝 `src/cascadia/UnitTests_TerminalCore/UnitTests.vcxproj` (+3 -0) </details> ### 📄 Description ## Summary of the Pull Request In #4213 I added a dependency to the `UnitTests_TerminalCore` project on basically all of conhost. This _worked on my machine_, but it's consistently not working on other machines. This should fix those issues. ## References ## PR Checklist * [x] Closes #4285 * [x] I work here * [n/a] Tests added/passed * [n/a] Requires documentation to be updated ## Validation Steps Performed Made a fresh clone and built it. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:11:15 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25706