starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #4342] [MERGED] Allow string values (like "system") in the rowsToScroll schema #25715

New Issue
Open
opened 2026-01-31 09:11:19 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:11:19 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/4342
Author: @iamakulov
Created: 1/23/2020
Status: ✅ Merged
Merged: 1/24/2020
Merged by: @DHowett-MSFT

Base: master ← Head: patch-1

📝 Commits (1)

  • b5d4c93 Allow string values (like "system") in the rowsToScroll schema

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 doc/cascadia/profiles.schema.json (+1 -1)

📄 Description

Summary of the Pull Request

In https://github.com/microsoft/terminal/pull/3575, Terminal added support for the rowsToScroll field – which accepts integers or "system". However, the settings schema only allows integers:

e675de3a88/doc/cascadia/profiles.schema.json (L289-L295)

which means writing rowsToScroll: "system" produces the following warning:

image

This PR fixes the issue.

PR Checklist

  • Closes #xxx
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Validation Steps Performed

  1. Opened settings and replaced the $schema field with the updated schema from my fork (https://raw.githubusercontent.com/iamakulov/terminal/b5d4c9337d3f323613dd5209bb68decb86cce667/doc/cascadia/profiles.schema.json).
  2. Validated that the "system" value doesn’t produce the warning anymore
  3. Validated that the value of false (i.e., a boolean – a type that’s not accepted) still produces a warning

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/4342 **Author:** [@iamakulov](https://github.com/iamakulov) **Created:** 1/23/2020 **Status:** ✅ Merged **Merged:** 1/24/2020 **Merged by:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Base:** `master` ← **Head:** `patch-1` --- ### 📝 Commits (1) - [`b5d4c93`](https://github.com/microsoft/terminal/commit/b5d4c9337d3f323613dd5209bb68decb86cce667) Allow string values (like "system") in the `rowsToScroll` schema ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `doc/cascadia/profiles.schema.json` (+1 -1) </details> ### 📄 Description <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request In https://github.com/microsoft/terminal/pull/3575, Terminal added support for the `rowsToScroll` field – which accepts integers or `"system"`. However, the settings schema only allows integers: https://github.com/microsoft/terminal/blob/e675de3a881dfc70bd018e2593ad6e3043d2d13c/doc/cascadia/profiles.schema.json#L289-L295 which means writing `rowsToScroll: "system"` produces the following warning: ![image](https://user-images.githubusercontent.com/2953267/72982139-78b7a200-3def-11ea-8ab8-5e25e324cc6f.png) This PR fixes the issue. <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [ ] Closes #xxx * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Requires documentation to be updated * [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed 1. Opened settings and replaced the `$schema` field with the updated schema from my fork (https://raw.githubusercontent.com/iamakulov/terminal/b5d4c9337d3f323613dd5209bb68decb86cce667/doc/cascadia/profiles.schema.json). 2. Validated that the `"system"` value doesn’t produce the warning anymore 3. Validated that the value of `false` (i.e., a boolean – a type that’s not accepted) still produces a warning --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:11:19 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25715
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?