[PR #4384] [CLOSED] Trying to figure out x64 test failures, don't review #25722

Open
opened 2026-01-31 09:11:22 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/4384
Author: @miniksa
Created: 1/28/2020
Status: Closed

Base: masterHead: dev/miniksa/tests


📝 Commits (10+)

  • 8ec3995 Disable most of the building of things to try to diagnose the test issue.
  • f5904b4 remove more parts of the build
  • 70dd675 stop codesign validation step for nonproduction scenario"
  • 39da4f0 try harder to turn off codesign validation.
  • dca2a40 turn more tests on since it's not failing.
  • 4e330fa til tests back on.
  • 2b4d3f5 turn on terminal core unit tests too.
  • c37a62f turn settings back on because CI failed.
  • 9628a43 turn off all tests except terminalcore
  • c127989 Merge branch 'master' into dev/miniksa/tests

📊 Changes

3 files changed (+55 additions, -87 deletions)

View changed files

📝 OpenConsole.sln (+0 -32)
📝 build/pipelines/ci.yml (+10 -10)
📝 build/pipelines/templates/build-console-steps.yml (+45 -45)

📄 Description

Go away. You heard me.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/4384 **Author:** [@miniksa](https://github.com/miniksa) **Created:** 1/28/2020 **Status:** ❌ Closed **Base:** `master` ← **Head:** `dev/miniksa/tests` --- ### 📝 Commits (10+) - [`8ec3995`](https://github.com/microsoft/terminal/commit/8ec39959b18e69a3774e90b55a1d77244377202e) Disable most of the building of things to try to diagnose the test issue. - [`f5904b4`](https://github.com/microsoft/terminal/commit/f5904b4a311640b66e9fa3b2c7957aa35b41a00d) remove more parts of the build - [`70dd675`](https://github.com/microsoft/terminal/commit/70dd6752cc2d2b48f5f27ae04a45175a45818566) stop codesign validation step for nonproduction scenario" - [`39da4f0`](https://github.com/microsoft/terminal/commit/39da4f01aedaed5597770369110b14e8da142990) try harder to turn off codesign validation. - [`dca2a40`](https://github.com/microsoft/terminal/commit/dca2a40f11a1e6b113bb1e87ff5f7fca0572f55b) turn more tests on since it's not failing. - [`4e330fa`](https://github.com/microsoft/terminal/commit/4e330fafedee87e065323adc9ad43b032e3ca5ac) til tests back on. - [`2b4d3f5`](https://github.com/microsoft/terminal/commit/2b4d3f5194a9864366f249f4c010d079d7da9f72) turn on terminal core unit tests too. - [`c37a62f`](https://github.com/microsoft/terminal/commit/c37a62fc0c84cd249646f71e3971055430894f7b) turn settings back on because CI failed. - [`9628a43`](https://github.com/microsoft/terminal/commit/9628a43051586adedf1a1a4a8b61e50bfcbe5d28) turn off all tests except terminalcore - [`c127989`](https://github.com/microsoft/terminal/commit/c1279894c5ee8f3c6f14a29fbd2e140a65507a1c) Merge branch 'master' into dev/miniksa/tests ### 📊 Changes **3 files changed** (+55 additions, -87 deletions) <details> <summary>View changed files</summary> 📝 `OpenConsole.sln` (+0 -32) 📝 `build/pipelines/ci.yml` (+10 -10) 📝 `build/pipelines/templates/build-console-steps.yml` (+45 -45) </details> ### 📄 Description Go away. You heard me. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:11:22 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25722