[PR #4400] [MERGED] Add privacy policy to about dialog #25734

Open
opened 2026-01-31 09:11:27 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/4400
Author: @cinnamon-msft
Created: 1/29/2020
Status: Merged
Merged: 1/29/2020
Merged by: @DHowett-MSFT

Base: masterHead: cinnamon/privacy-policy


📝 Commits (1)

  • df848df add privacy policy to about dialog

📊 Changes

2 files changed (+19 additions, -2 deletions)

View changed files

📝 src/cascadia/TerminalApp/Resources/en-US/Resources.resw (+7 -0)
📝 src/cascadia/TerminalApp/TerminalPage.cpp (+12 -2)

📄 Description

Summary of the Pull Request

Added a link to our privacy policy inside the About dialog box

References

PR Checklist

  • Closes Virtual terminal wrongly parsed input buffer under load (#4281)
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Links to https://aka.ms/terminal-privacy-policy
image

Validation Steps Performed


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/4400 **Author:** [@cinnamon-msft](https://github.com/cinnamon-msft) **Created:** 1/29/2020 **Status:** ✅ Merged **Merged:** 1/29/2020 **Merged by:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Base:** `master` ← **Head:** `cinnamon/privacy-policy` --- ### 📝 Commits (1) - [`df848df`](https://github.com/microsoft/terminal/commit/df848df519253bbacd18552ce4d551a88ebff895) add privacy policy to about dialog ### 📊 Changes **2 files changed** (+19 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/Resources/en-US/Resources.resw` (+7 -0) 📝 `src/cascadia/TerminalApp/TerminalPage.cpp` (+12 -2) </details> ### 📄 Description <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request Added a link to our privacy policy inside the About dialog box <!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> ## References <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [x] Closes #4281 * [ ] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Requires documentation to be updated * [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments Links to https://aka.ms/terminal-privacy-policy ![image](https://user-images.githubusercontent.com/48369326/73394494-96bf4f80-4292-11ea-9c83-985d4eddec2a.png) <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:11:27 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25734