starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #4392] [MERGED] Add VS Code keys and improve keybinding documentation #25735

New Issue
Open
opened 2026-01-31 09:11:28 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:11:28 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/4392
Author: @cinnamon-msft
Created: 1/29/2020
Status: ✅ Merged
Merged: 2/4/2020
Merged by: @cinnamon-msft

Base: master ← Head: cinnamon/vs-code-keybindings

📝 Commits (10+)

  • db83391 initial vs code keybinding functionality + initial keybinding documentation
  • aa8f008 updated docs
  • def4a4e add descriptions to commands
  • 66cf590 added descriptions of actions
  • 98ad80e addressed feedback
  • 000a679 Update doc/cascadia/SettingsSchema.md
  • 6d48168 Update doc/cascadia/SettingsSchema.md
  • ebaa66d Update doc/cascadia/SettingsSchema.md
  • ac3827a Update doc/cascadia/SettingsSchema.md
  • b17008e Update doc/cascadia/SettingsSchema.md

📊 Changes

2 files changed (+143 additions, -133 deletions)

View changed files

📝 doc/cascadia/SettingsSchema.md (+57 -63)
📝 src/cascadia/TerminalApp/KeyChordSerialization.cpp (+86 -70)

📄 Description

Summary of the Pull Request

Add keybinding keys to be compatible with VS Code conventions: https://code.visualstudio.com/docs/getstarted/keybindings#_accepted-keys

Improve keybinding documentation because we desperately need it. :)

(Documentation will definitely be iterated on, just wanted to get this PR rolling.)

References

#3809

PR Checklist

  • Closes Clicking on the TitleBar does not close the dropdown menu (#3140)
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Tested the new keys

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/4392 **Author:** [@cinnamon-msft](https://github.com/cinnamon-msft) **Created:** 1/29/2020 **Status:** ✅ Merged **Merged:** 2/4/2020 **Merged by:** [@cinnamon-msft](https://github.com/cinnamon-msft) **Base:** `master` ← **Head:** `cinnamon/vs-code-keybindings` --- ### 📝 Commits (10+) - [`db83391`](https://github.com/microsoft/terminal/commit/db833919fc728b2865c3c4c69bb221bea1041cb0) initial vs code keybinding functionality + initial keybinding documentation - [`aa8f008`](https://github.com/microsoft/terminal/commit/aa8f008f096cef748e5b5fa895edc2fa56d0f54f) updated docs - [`def4a4e`](https://github.com/microsoft/terminal/commit/def4a4e2cc52662afc20e1078ce7374d03f4e550) add descriptions to commands - [`66cf590`](https://github.com/microsoft/terminal/commit/66cf590c245a8cd661821f7cb66f9d4ce5ecfa90) added descriptions of actions - [`98ad80e`](https://github.com/microsoft/terminal/commit/98ad80ecaf9360b303b4dda840cc2ff0b24b6d01) addressed feedback - [`000a679`](https://github.com/microsoft/terminal/commit/000a67980018d722006dfc7233da585ac54fc1ef) Update doc/cascadia/SettingsSchema.md - [`6d48168`](https://github.com/microsoft/terminal/commit/6d481689c8ffd34a52721cc4d79d829e62d0ebbb) Update doc/cascadia/SettingsSchema.md - [`ebaa66d`](https://github.com/microsoft/terminal/commit/ebaa66dd465a30b0f48ba4191a899d8c0b116461) Update doc/cascadia/SettingsSchema.md - [`ac3827a`](https://github.com/microsoft/terminal/commit/ac3827ad109d5317e0fb78f9fb51b393acc0c6b1) Update doc/cascadia/SettingsSchema.md - [`b17008e`](https://github.com/microsoft/terminal/commit/b17008e137fe9d0a7211e3f77a96967244c72cf3) Update doc/cascadia/SettingsSchema.md ### 📊 Changes **2 files changed** (+143 additions, -133 deletions) <details> <summary>View changed files</summary> 📝 `doc/cascadia/SettingsSchema.md` (+57 -63) 📝 `src/cascadia/TerminalApp/KeyChordSerialization.cpp` (+86 -70) </details> ### 📄 Description <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request Add keybinding keys to be compatible with VS Code conventions: https://code.visualstudio.com/docs/getstarted/keybindings#_accepted-keys Improve keybinding documentation because we desperately need it. :) (Documentation will definitely be iterated on, just wanted to get this PR rolling.) <!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> ## References #3809 <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [x] Closes #3140 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Requires documentation to be updated * [x] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed Tested the new keys --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:11:28 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25735
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?