[PR #4449] [MERGED] Adjust GetBoundingRect() for Inclusive end #25762

Open
opened 2026-01-31 09:11:39 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/4449
Author: @carlos-zamora
Created: 2/3/2020
Status: Merged
Merged: 2/3/2020
Merged by: @carlos-zamora

Base: masterHead: dev/cazamor/acc/bugfix-utr-getboundingrect


📝 Commits (1)

  • e7e3e53 Adjust GetBoundingRect for Inclusive end

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 src/types/UiaTextRangeBase.cpp (+2 -2)

📄 Description

Summary of the Pull Request

GetBoundingRect() has inclusive endpoints. I previously assumed end was exclusive so I drew the bounding rect wrong.

This also means that we should allow start and end to be the same. Which means that FailFastIf would get hit...


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/4449 **Author:** [@carlos-zamora](https://github.com/carlos-zamora) **Created:** 2/3/2020 **Status:** ✅ Merged **Merged:** 2/3/2020 **Merged by:** [@carlos-zamora](https://github.com/carlos-zamora) **Base:** `master` ← **Head:** `dev/cazamor/acc/bugfix-utr-getboundingrect` --- ### 📝 Commits (1) - [`e7e3e53`](https://github.com/microsoft/terminal/commit/e7e3e538b415de6bd72ee00c5fbe0ff3e2ef5b92) Adjust GetBoundingRect for Inclusive end ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/types/UiaTextRangeBase.cpp` (+2 -2) </details> ### 📄 Description ## Summary of the Pull Request `GetBoundingRect()` has inclusive endpoints. I previously assumed end was exclusive so I drew the bounding rect wrong. This also means that we should allow start and end to be the same. Which means that FailFastIf would get hit... --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:11:39 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25762