[PR #4433] [MERGED] Passthrough CSI 3 J in Conpty #25763

Open
opened 2026-01-31 09:11:39 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/4433
Author: @zadjii-msft
Created: 1/31/2020
Status: Merged
Merged: 2/10/2020
Merged by: @undefined

Base: masterHead: dev/migrie/b/2715


📝 Commits (4)

  • 9733a9f This at a minimum passes the sequences through
  • 0b87ee3 Stashing this for now - I need the tests configured as they are in #4354 for this to be testable
  • 1676803 Merge remote-tracking branch 'origin/master' into dev/migrie/b/2715
  • 4f5ab80 This fixes the test for #2715

📊 Changes

2 files changed (+96 additions, -1 deletions)

View changed files

📝 src/cascadia/UnitTests_TerminalCore/ConptyRoundtripTests.cpp (+77 -0)
📝 src/terminal/adapter/adaptDispatch.cpp (+19 -1)

📄 Description

Summary of the Pull Request

Conpty doesn't need CSI 3 J, it doesn't have a scrollback. The terminal that's connected should use that. This makes conpty pass it through, like other sequences that conpty has no need for.

References

PR Checklist


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/4433 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 1/31/2020 **Status:** ✅ Merged **Merged:** 2/10/2020 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `dev/migrie/b/2715` --- ### 📝 Commits (4) - [`9733a9f`](https://github.com/microsoft/terminal/commit/9733a9ff2a1be98d09b31dd4b07d285e14c30292) This at a minimum passes the sequences through - [`0b87ee3`](https://github.com/microsoft/terminal/commit/0b87ee3b4366acf31e36478ca6941ecb8554a768) Stashing this for now - I need the tests configured as they are in #4354 for this to be testable - [`1676803`](https://github.com/microsoft/terminal/commit/1676803b78820a0b5b72fbe627d3d795488b526a) Merge remote-tracking branch 'origin/master' into dev/migrie/b/2715 - [`4f5ab80`](https://github.com/microsoft/terminal/commit/4f5ab8010965fd161806eaab8efb7d0e88ddc54a) This fixes the test for #2715 ### 📊 Changes **2 files changed** (+96 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/UnitTests_TerminalCore/ConptyRoundtripTests.cpp` (+77 -0) 📝 `src/terminal/adapter/adaptDispatch.cpp` (+19 -1) </details> ### 📄 Description ## Summary of the Pull Request Conpty doesn't need `CSI 3 J`, it doesn't have a scrollback. The terminal that's connected should use that. This makes conpty pass it through, like other sequences that conpty has no need for. ## References ## PR Checklist * [x] Closes #2715 * [x] I work here * [x] Tests added/passed * [n/a] Requires documentation to be updated --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:11:39 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25763