starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #4538] [MERGED] Fix the crash when closing Terminal containing multiple tabs. #25813

New Issue
Open
opened 2026-01-31 09:11:57 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:11:57 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/4538
Author: @leonMSFT
Created: 2/11/2020
Status: ✅ Merged
Merged: 2/11/2020
Merged by: @undefined

Base: master ← Head: dev/lelian/crashonclose

📝 Commits (3)

  • 9b1b677 removing the chunk of problematic code that isn't really needed
  • 796e66a whoops didn't remove comments
  • b49ee40 Merge branch 'master' into dev/lelian/crashonclose

📊 Changes

1 file changed (+0 additions, -19 deletions)

View changed files

📝 src/cascadia/TerminalApp/TerminalPage.cpp (+0 -19)

📄 Description

The Terminal would crash when closing it when there are multiple tabs
open. This was due to TerminalPage attempting to select a nonexistent
tab.

The block of code that was removed was causing issues when trying to
close all tabs at once. The way we close all our tabs in
_CloseAllTabs() was by repeatedly calling
_RemoveTabViewItemByIndex(0) until _tabs.Size() == 0. The problem
was that _RemoveTabViewItemByIndex would eventually call a coroutine
to set the next tab as the SelectedItem after removing a tab. The
coroutine would then pass control back to _CloseAllTabs() to finish
its loop, and by the time the coroutine resumes control, _tabs and
TabView().TabItems() would both be empty and it would crash attempting
to focus a tab.

Luckily, the functionality that this block of code provided is really no
longer needed . This code was used to focus on the next tab after
closing a tab. This might have been written way back when TabView
didn't have this functionality built in. It seems now that after
removing a TabItem from the TabView, the SelectedItem of the
TabView automatically updates, making this block of code unnecessary.

Validation Steps Performed

Did a lot of multiple tab open and closings and closing the window after
opening a ton of tabs. No crashes seem to occur anymore!
Test cases still pass.

Closes #4482

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/4538 **Author:** [@leonMSFT](https://github.com/leonMSFT) **Created:** 2/11/2020 **Status:** ✅ Merged **Merged:** 2/11/2020 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `dev/lelian/crashonclose` --- ### 📝 Commits (3) - [`9b1b677`](https://github.com/microsoft/terminal/commit/9b1b67756b8c2052ad99e422d69c6e6b90d5ce75) removing the chunk of problematic code that isn't really needed - [`796e66a`](https://github.com/microsoft/terminal/commit/796e66ae0598aa740da0985a4d700038d1131852) whoops didn't remove comments - [`b49ee40`](https://github.com/microsoft/terminal/commit/b49ee409e01fa116a26cb6f296b2427f66b2a55b) Merge branch 'master' into dev/lelian/crashonclose ### 📊 Changes **1 file changed** (+0 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/TerminalPage.cpp` (+0 -19) </details> ### 📄 Description The Terminal would crash when closing it when there are multiple tabs open. This was due to `TerminalPage` attempting to select a nonexistent tab. The block of code that was removed was causing issues when trying to close all tabs at once. The way we close all our tabs in `_CloseAllTabs()` was by repeatedly calling `_RemoveTabViewItemByIndex(0)` until `_tabs.Size() == 0`. The problem was that `_RemoveTabViewItemByIndex` would eventually call a coroutine to set the next tab as the `SelectedItem` after removing a tab. The coroutine would then pass control back to `_CloseAllTabs()` to finish its loop, and by the time the coroutine resumes control, `_tabs` and `TabView().TabItems()` would both be empty and it would crash attempting to focus a tab. Luckily, the functionality that this block of code provided is really no longer needed . This code was used to focus on the next tab after closing a tab. This might have been written way back when TabView didn't have this functionality built in. It seems now that after removing a `TabItem` from the `TabView`, the `SelectedItem` of the TabView automatically updates, making this block of code unnecessary. ## Validation Steps Performed Did a lot of multiple tab open and closings and closing the window after opening a ton of tabs. No crashes seem to occur anymore! Test cases still pass. Closes #4482 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:11:57 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25813
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?