[PR #4651] [MERGED] Add cursorColor to color scheme #25875

Open
opened 2026-01-31 09:12:21 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/4651
Author: @yitzhaks
Created: 2/20/2020
Status: ✅ Merged
Merged: 3/17/2020
Merged by: @undefined

Base: master ← Head: dev/yitzhaks/CursorColorInColorScheme


📝 Commits (7)

  • e326375 Add cursorColor to color scheme
  • 163f586 Make the formatter happy
  • 692924e Update the profiles schema documentation
  • ec21c51 Add a test
  • 8fc3e18 Fix json schema
  • c8e4268 Fix wording
  • e1eb664 Merge branch 'master' into dev/yitzhaks/CursorColorInColorScheme

📊 Changes

10 files changed (+127 additions, -21 deletions)

View changed files

📝 doc/cascadia/SettingsSchema.md (+2 -1)
📝 doc/cascadia/profiles.schema.json (+6 -2)
📝 src/cascadia/LocalTests_TerminalApp/ColorSchemeTests.cpp (+6 -1)
📝 src/cascadia/LocalTests_TerminalApp/SettingsTests.cpp (+71 -1)
📝 src/cascadia/TerminalApp/ColorScheme.cpp (+18 -3)
📝 src/cascadia/TerminalApp/ColorScheme.h (+3 -1)
📝 src/cascadia/TerminalApp/Profile.cpp (+11 -9)
📝 src/cascadia/TerminalApp/Profile.h (+1 -1)
📝 src/cascadia/TerminalApp/defaults.json (+7 -2)
📝 src/cascadia/ut_app/JsonTests.cpp (+2 -0)

📄 Description

Add the option to set the cursor color as part of the color scheme.

This is very useful for light themes, where the cursor disappears unless its color
is set in the profile.

Related to issue #764, but doesn't fully resolve it.

Validation

I tested this manually by creating a light color scheme, setting the cursor color
to black and setting the profile color scheme to the newly created color scheme.
I validated the cursor is black, then set the cursor color in the profile (to red)
and saw it trumps the cursor color from the color scheme.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/4651 **Author:** [@yitzhaks](https://github.com/yitzhaks) **Created:** 2/20/2020 **Status:** ✅ Merged **Merged:** 3/17/2020 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `dev/yitzhaks/CursorColorInColorScheme` --- ### 📝 Commits (7) - [`e326375`](https://github.com/microsoft/terminal/commit/e326375eb5cd8ca646eb2136d5d10d27688e95d0) Add cursorColor to color scheme - [`163f586`](https://github.com/microsoft/terminal/commit/163f586967d3c06c854ea8e49fcf00b1c18bc18f) Make the formatter happy - [`692924e`](https://github.com/microsoft/terminal/commit/692924ea587b63495ed08b1a3aa1879b4d37d96b) Update the profiles schema documentation - [`ec21c51`](https://github.com/microsoft/terminal/commit/ec21c51d65a0681b404260f04d87555355061176) Add a test - [`8fc3e18`](https://github.com/microsoft/terminal/commit/8fc3e183073b31aa8a0e244190975795f8bc16b9) Fix json schema - [`c8e4268`](https://github.com/microsoft/terminal/commit/c8e4268ec1e1e93b81b0de8ffa7f62706dfeacca) Fix wording - [`e1eb664`](https://github.com/microsoft/terminal/commit/e1eb6643eec75d4cc13d999fa23796d061c969a8) Merge branch 'master' into dev/yitzhaks/CursorColorInColorScheme ### 📊 Changes **10 files changed** (+127 additions, -21 deletions) <details> <summary>View changed files</summary> 📝 `doc/cascadia/SettingsSchema.md` (+2 -1) 📝 `doc/cascadia/profiles.schema.json` (+6 -2) 📝 `src/cascadia/LocalTests_TerminalApp/ColorSchemeTests.cpp` (+6 -1) 📝 `src/cascadia/LocalTests_TerminalApp/SettingsTests.cpp` (+71 -1) 📝 `src/cascadia/TerminalApp/ColorScheme.cpp` (+18 -3) 📝 `src/cascadia/TerminalApp/ColorScheme.h` (+3 -1) 📝 `src/cascadia/TerminalApp/Profile.cpp` (+11 -9) 📝 `src/cascadia/TerminalApp/Profile.h` (+1 -1) 📝 `src/cascadia/TerminalApp/defaults.json` (+7 -2) 📝 `src/cascadia/ut_app/JsonTests.cpp` (+2 -0) </details> ### 📄 Description Add the option to set the cursor color as part of the color scheme. This is very useful for light themes, where the cursor disappears unless its color is set in the profile. Related to issue #764, but doesn't fully resolve it. ## Validation I tested this manually by creating a light color scheme, setting the cursor color to black and setting the profile color scheme to the newly created color scheme. I validated the cursor is black, then set the cursor color in the profile (to red) and saw it trumps the cursor color from the color scheme. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:12:21 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25875