starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 00:15:10 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #4652] [MERGED] Shim the Azure connection through a conhost to stop VT bleeding #25876

New Issue
Open
opened 2026-01-31 09:12:21 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:12:21 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/4652
Author: @DHowett-MSFT
Created: 2/20/2020
Status: ✅ Merged
Merged: 2/21/2020
Merged by: @DHowett-MSFT

Base: master ← Head: dev/duhowett/azbridghe

📝 Commits (4)

  • f82565e Shim the Azure connection through a conhost to stop VT bleeding
  • 005897e Fix GH#ID and WRAP_AT_EOL
  • 1f42666 Apply suggestions from code review
  • 1441dde If we get a high/non or non/low, emit U+FFFD

📊 Changes

10 files changed (+361 additions, -2 deletions)

View changed files

📝 OpenConsole.sln (+17 -0)
📝 src/cascadia/CascadiaPackage/CascadiaPackage.wapproj (+1 -0)
📝 src/cascadia/TerminalApp/TerminalPage.cpp (+4 -2)
➕ src/cascadia/TerminalAzBridge/ConsoleInputReader.cpp (+87 -0)
➕ src/cascadia/TerminalAzBridge/ConsoleInputReader.h (+33 -0)
➕ src/cascadia/TerminalAzBridge/TerminalAzBridge.vcxproj (+71 -0)
➕ src/cascadia/TerminalAzBridge/main.cpp (+104 -0)
➕ src/cascadia/TerminalAzBridge/packages.config (+4 -0)
➕ src/cascadia/TerminalAzBridge/pch.cpp (+4 -0)
➕ src/cascadia/TerminalAzBridge/pch.h (+36 -0)

📄 Description

This commit introduces a small console-subsystem application whose sole
job is to consume TerminalConnection.dll and hook it up to something
other than Terminal. It is 99% of the way to a generic solution.

I've introduced a stopgap in TerminalPage that makes sure we launch
TerminalAzBridge using ConptyConnection instead of AzureConnection.

As a bonus, this commit includes a class whose sole job it is to make
reading VT input off a console handle not terrible. It returns you a
string and dispatches window size change callbacks.

Fixes #2267.
Fixes #4589.
Related to #2266 (since pwsh needs better VT).

NOTE: this application will only work if you put TerminalConnection.dll and resources.pri next to it. It is not yet intended for out-of-terminal-package use.

Validation Steps Performed

image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/4652 **Author:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Created:** 2/20/2020 **Status:** ✅ Merged **Merged:** 2/21/2020 **Merged by:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Base:** `master` ← **Head:** `dev/duhowett/azbridghe` --- ### 📝 Commits (4) - [`f82565e`](https://github.com/microsoft/terminal/commit/f82565e9adc7cf96616cc28bdedfc6b86b139237) Shim the Azure connection through a conhost to stop VT bleeding - [`005897e`](https://github.com/microsoft/terminal/commit/005897eaf3d6144dff08766a2726fb3826d8bb79) Fix GH#ID and WRAP_AT_EOL - [`1f42666`](https://github.com/microsoft/terminal/commit/1f42666c30b4a7745e08b1fddf4009ff5afd2181) Apply suggestions from code review - [`1441dde`](https://github.com/microsoft/terminal/commit/1441dde7ec1e06850fefd97589f95d3245601ac4) If we get a high/non or non/low, emit U+FFFD ### 📊 Changes **10 files changed** (+361 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `OpenConsole.sln` (+17 -0) 📝 `src/cascadia/CascadiaPackage/CascadiaPackage.wapproj` (+1 -0) 📝 `src/cascadia/TerminalApp/TerminalPage.cpp` (+4 -2) ➕ `src/cascadia/TerminalAzBridge/ConsoleInputReader.cpp` (+87 -0) ➕ `src/cascadia/TerminalAzBridge/ConsoleInputReader.h` (+33 -0) ➕ `src/cascadia/TerminalAzBridge/TerminalAzBridge.vcxproj` (+71 -0) ➕ `src/cascadia/TerminalAzBridge/main.cpp` (+104 -0) ➕ `src/cascadia/TerminalAzBridge/packages.config` (+4 -0) ➕ `src/cascadia/TerminalAzBridge/pch.cpp` (+4 -0) ➕ `src/cascadia/TerminalAzBridge/pch.h` (+36 -0) </details> ### 📄 Description This commit introduces a small console-subsystem application whose sole job is to consume TerminalConnection.dll and hook it up to something other than Terminal. It is 99% of the way to a generic solution. I've introduced a stopgap in TerminalPage that makes sure we launch TerminalAzBridge using ConptyConnection instead of AzureConnection. As a bonus, this commit includes a class whose sole job it is to make reading VT input off a console handle not terrible. It returns you a string and dispatches window size change callbacks. Fixes #2267. Fixes #4589. Related to #2266 (since pwsh needs better VT). _NOTE: this application will only work if you put TerminalConnection.dll and resources.pri next to it. It is not yet intended for out-of-terminal-package use._ ## Validation Steps Performed ![image](https://user-images.githubusercontent.com/14316954/74894833-ebf7f980-5344-11ea-93ff-d96d36925c4c.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:12:21 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25876
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?